[ECP-9912] Configure NOK currency for E2E tests#3256
Conversation
Summary of ChangesHello @candemiralp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Makefile target to streamline the setup process for End-to-End tests, particularly for the Vipps payment method. It configures the Magento environment to allow Norwegian Krone (NOK) currency and sets an exchange rate from EUR to NOK, which is crucial for testing specific payment flows. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a new setup-e2e target in the Makefile to configure NOK currency for E2E tests. This includes setting allowed currencies, inserting a currency rate into the database, and flushing the cache. The changes are straightforward and address the stated objective.
| mysql -h "$$DB_SERVER" -P "$$DB_PORT" -u "$$DB_USER" -p"$$DB_PASSWORD" "$$DB_NAME" -e \ | ||
| "INSERT INTO $${DB_PREFIX}directory_currency_rate (currency_from, currency_to, rate) VALUES ('EUR', 'NOK', 11) ON DUPLICATE KEY UPDATE rate = VALUES(rate);" |
There was a problem hiding this comment.
The INSERT ... ON DUPLICATE KEY UPDATE statement is generally good for idempotency. However, directly embedding SQL with string concatenation for DB_PREFIX can be a security risk if DB_PREFIX is user-controlled or not properly sanitized. While DB_PREFIX is likely an internal variable in a Makefile, it's a good practice to be cautious with direct SQL injection possibilities. Consider using a more robust method for database interaction if DB_PREFIX could ever be influenced by external input, or ensure it's strictly controlled.
|
2 participants
Description
This configuration change is required to perform E2E tests for Vipps payment method. Please see the test PR.