[ECP-9911] Append Magento edition to externalPlatform.name in applicationInfo#3259
[ECP-9911] Append Magento edition to externalPlatform.name in applicationInfo#3259shubhamk67 merged 2 commits intomainfrom
Conversation
Summary of ChangesHello @shubhamk67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the platform information sent to Adyen by incorporating the specific Magento edition into the platform name. This enhancement allows Adyen to receive more precise details about the originating Magento environment, which can be beneficial for reporting, analytics, and tailored service offerings, without altering the core functionality of the payment processing. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully appends the Magento edition to the external platform name in applicationInfo, which aligns with the stated goal. The changes are clear and address the requirement. However, there's a minor improvement opportunity to ensure that an extra space is not added if the edition string is empty, which could lead to inconsistent naming.
| $platformIntegratorName = $this->configHelper->getPlatformIntegratorName(); | ||
| $platformIntegrator = ($hasPlatformIntegrator && $platformIntegratorName) ? $platformIntegratorName : ''; | ||
| $client->setExternalPlatform($platformData['name'], $platformData['version'], $platformIntegrator); | ||
| $platformName = $platformData['name'] . ' ' . $platformData['edition']; |
There was a problem hiding this comment.
To prevent an extra space from appearing in platformName if $platformData['edition'] is empty, consider using trim() around the concatenated string. This ensures a clean output regardless of whether an edition is present.
$platformName = trim($platformData['name'] . ' ' . $platformData['edition']);| [ApplicationInfo::VERSION] = $this->productMetadata->getVersion(); | ||
| $saleToAcquirerData[ApplicationInfo::APPLICATION_INFO][ApplicationInfo::EXTERNAL_PLATFORM] | ||
| [ApplicationInfo::NAME] = $this->productMetadata->getName(); | ||
| [ApplicationInfo::NAME] = $this->productMetadata->getName() . ' ' . $this->productMetadata->getEdition(); |
There was a problem hiding this comment.
Similar to the Helper/Data.php file, if getEdition() returns an empty string, this concatenation will result in an unnecessary trailing space. Using trim() will ensure the string is correctly formatted in all cases.
[ApplicationInfo::NAME] = trim($this->productMetadata->getName() . ' ' . $this->productMetadata->getEdition());
|
3 participants
Description
Magento/Adobe Commerce has different application editions (Community, Enterprise, etc.). This change appends the edition to the externalPlatform.name field sent in applicationInfo to Adyen, so the name will now be "Magento Community" or "Magento Enterprise" instead of just "Magento".