-
Notifications
You must be signed in to change notification settings - Fork 85
[recurring] Code generation: update services and models #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, generated automatically, updates the services and models for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated update for the recurring service. While the documentation updates in src/typings/recurring/amount.ts are fine, the change to API_BASEPATH in src/services/recurring/recurringApi.ts introduces a critical regression. It breaks the logic for generating production (LIVE) environment URLs, as the base Service class contains hardcoded logic expecting the old URL format. This will cause API calls to fail in production. Furthermore, existing unit tests for this service will fail as they are configured to mock the old URL. This change should not be merged without addressing the related issues in service.ts and the corresponding test files.
| export class RecurringApi extends Service { | ||
|
|
||
| private readonly API_BASEPATH: string = "https://pal-test.adyen.com/pal/servlet/Recurring/v68"; | ||
| private readonly API_BASEPATH: string = "https://paltokenization-test.adyen.com/pal/servlet/Recurring/v68"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change to API_BASEPATH introduces a critical issue. The Service.createBaseUrl method, which is responsible for generating the correct URL for different environments (like LIVE), relies on the old URL structure to generate the live endpoint URL.
Specifically, the logic in src/service.ts at line 66:
return url.replace("https://pal-test.adyen.com/pal/servlet/",
`https://${this.client.config.liveEndpointUrlPrefix}-pal-live.adyenpayments.com/pal/servlet/`);will no longer work with the new base path https://paltokenization-test.adyen.com/.... The replace call will not find a match, causing requests in the LIVE environment to be sent to the test URL, which will likely fail.
Additionally, the unit tests in src/__tests__/recurring.spec.ts are now broken as they use nock to mock the old URL (https://pal-test.adyen.com/...) on line 31.
To fix this, the logic in Service.createBaseUrl needs to be updated to handle the new URL structure, and the test mocks in src/__tests__/recurring.spec.ts must be updated to the new endpoint. Since these files are not part of this PR, this change as-is will break existing functionality.
f7d3d30 to
ab3038d
Compare
ab3038d to
f1e5900
Compare
This PR contains the automated changes for the
recurringservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.