Skip to content

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the recurring service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 14, 2026 09:18
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, generated automatically, updates the services and models for the recurring service. The primary purpose is to synchronize the codebase with recent changes in the adyen-openapi specification, which includes an important update to the API base path for recurring operations and minor enhancements to documentation for better understanding of data models.

Highlights

  • API Endpoint Update: The API_BASEPATH for the RecurringApi service has been updated to point to https://paltokenization-test.adyen.com/pal/servlet/Recurring/v68, indicating a change in the target environment or service path.
  • Documentation Clarity: JSDoc comments for the currency and value properties within the Amount class have been refined for improved clarity and precision.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated update for the recurring service. While the documentation updates in src/typings/recurring/amount.ts are fine, the change to API_BASEPATH in src/services/recurring/recurringApi.ts introduces a critical regression. It breaks the logic for generating production (LIVE) environment URLs, as the base Service class contains hardcoded logic expecting the old URL format. This will cause API calls to fail in production. Furthermore, existing unit tests for this service will fail as they are configured to mock the old URL. This change should not be merged without addressing the related issues in service.ts and the corresponding test files.

export class RecurringApi extends Service {

private readonly API_BASEPATH: string = "https://pal-test.adyen.com/pal/servlet/Recurring/v68";
private readonly API_BASEPATH: string = "https://paltokenization-test.adyen.com/pal/servlet/Recurring/v68";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change to API_BASEPATH introduces a critical issue. The Service.createBaseUrl method, which is responsible for generating the correct URL for different environments (like LIVE), relies on the old URL structure to generate the live endpoint URL.

Specifically, the logic in src/service.ts at line 66:

return url.replace("https://pal-test.adyen.com/pal/servlet/",
        `https://${this.client.config.liveEndpointUrlPrefix}-pal-live.adyenpayments.com/pal/servlet/`);

will no longer work with the new base path https://paltokenization-test.adyen.com/.... The replace call will not find a match, causing requests in the LIVE environment to be sent to the test URL, which will likely fail.

Additionally, the unit tests in src/__tests__/recurring.spec.ts are now broken as they use nock to mock the old URL (https://pal-test.adyen.com/...) on line 31.

To fix this, the logic in Service.createBaseUrl needs to be updated to handle the new URL structure, and the test mocks in src/__tests__/recurring.spec.ts must be updated to the new endpoint. Since these files are not part of this PR, this change as-is will break existing functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants