-
Notifications
You must be signed in to change notification settings - Fork 85
[payment] Code generation: update services and models #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by AdyenAutomationBot, updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR appears to be an automated code generation task to update services and models based on OpenAPI specifications. The changes mostly involve documentation updates, adding new enum values, and introducing new properties, which is consistent with an API update. My review focuses on the correctness and consistency of these generated changes. I've found a potential naming issue and a typo in src/typings/payment/responseAdditionalDataSepa.ts which I've detailed in the comments.
| * The date that the the shopper\'s bank account is charged. | ||
| */ | ||
| "sepadirectdebit_sepadirectdebit_dueDate"?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property name sepadirectdebit_sepadirectdebit_dueDate seems to have a redundant sepadirectdebit_ prefix. To maintain consistency with other properties in this class, it should probably be sepadirectdebit_dueDate.
Additionally, there is a typo in the comment on line 21 ('the the').
| * The date that the the shopper\'s bank account is charged. | |
| */ | |
| "sepadirectdebit_sepadirectdebit_dueDate"?: string; | |
| * The date that the shopper's bank account is charged. | |
| */ | |
| "sepadirectdebit_dueDate"?: string; |
| "name": "sepadirectdebit_sepadirectdebit_dueDate", | ||
| "baseName": "sepadirectdebit.sepadirectdebit.dueDate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To align with the suggested fix for the property name, the name and baseName here should also be corrected to remove the duplicated sepadirectdebit part.
| "name": "sepadirectdebit_sepadirectdebit_dueDate", | |
| "baseName": "sepadirectdebit.sepadirectdebit.dueDate", | |
| "name": "sepadirectdebit_dueDate", | |
| "baseName": "sepadirectdebit.dueDate", |
53febee to
490d5a4
Compare
490d5a4 to
f700827
Compare
This PR contains the automated changes for the
paymentservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.