-
Notifications
You must be signed in to change notification settings - Fork 85
[transferwebhooks] Code generation: update services and models #1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request contains automated updates to the services and models for transferwebhooks. The changes primarily consist of documentation updates, the addition of new enum values, and the introduction of new properties to existing models. While most of these changes appear to be routine updates, I have identified a critical issue in transferDataTracking.ts where the removal of a mapping object for a discriminated union is likely to cause runtime errors during webhook deserialization. This issue may also be present in other auto-generated files not included in this pull request's diff, so a broader check might be warranted.
| "estimation": "EstimationTrackingData", | ||
| "internalReview": "InternalReviewTrackingData" | ||
| }; | ||
| static readonly mapping: {[index: string]: string} | undefined = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the mapping object will likely break the deserialization of the TransferDataTracking union type. The ObjectSerializer.deserialize method relies on this mapping to resolve the concrete type from the type discriminator field in the JSON payload. Without it, the serializer won't be able to map values like "confirmation" to the ConfirmationTrackingData class, leading to runtime errors. Please restore the mapping to ensure proper deserialization.
static readonly mapping: {[index: string]: string} | undefined = {
"confirmation": "ConfirmationTrackingData",
"estimation": "EstimationTrackingData",
"internalReview": "InternalReviewTrackingData"
};7829e70 to
f9f3be9
Compare
f9f3be9 to
91e943f
Compare
This PR contains the automated changes for the
transferwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.