-
Notifications
You must be signed in to change notification settings - Fork 85
[transfers] Code generation: update services and models #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdyenAutomationBot
wants to merge
1
commit into
main
Choose a base branch
from
sdk-automation/transfers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * The version of the OpenAPI document: v4 | ||
| * | ||
| * | ||
| * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech). | ||
| * https://openapi-generator.tech | ||
| * Do not edit this class manually. | ||
| */ | ||
|
|
||
| import { CardIdentification } from "./cardIdentification"; | ||
|
|
||
|
|
||
| export class FundingInstrument { | ||
| "cardIdentification"?: CardIdentification | null; | ||
| /** | ||
| * The unique reference assigned by the card network for the pay-in transaction. | ||
| */ | ||
| "networkPaymentReference"?: string; | ||
| /** | ||
| * Your internal reference that identifies this funding instrument. Required if `sourceOfFunds` is **DEPOSIT_ACCOUNT**. | ||
| */ | ||
| "reference"?: string; | ||
| /** | ||
| * Indicates where the funds used for the transfer originated. Possible values are: - **DEBIT** for card-to-card transfers. - **DEPOSIT_ACCOUNT** for wallet-to-card transfers. | ||
| */ | ||
| "sourceOfFunds"?: FundingInstrument.SourceOfFundsEnum; | ||
|
|
||
| static readonly discriminator: string | undefined = undefined; | ||
|
|
||
| static readonly mapping: {[index: string]: string} | undefined = undefined; | ||
|
|
||
| static readonly attributeTypeMap: Array<{name: string, baseName: string, type: string, format: string}> = [ | ||
| { | ||
| "name": "cardIdentification", | ||
| "baseName": "cardIdentification", | ||
| "type": "CardIdentification | null", | ||
| "format": "" | ||
| }, | ||
| { | ||
| "name": "networkPaymentReference", | ||
| "baseName": "networkPaymentReference", | ||
| "type": "string", | ||
| "format": "" | ||
| }, | ||
| { | ||
| "name": "reference", | ||
| "baseName": "reference", | ||
| "type": "string", | ||
| "format": "" | ||
| }, | ||
| { | ||
| "name": "sourceOfFunds", | ||
| "baseName": "sourceOfFunds", | ||
| "type": "FundingInstrument.SourceOfFundsEnum", | ||
| "format": "" | ||
| } ]; | ||
|
|
||
| static getAttributeTypeMap() { | ||
| return FundingInstrument.attributeTypeMap; | ||
| } | ||
|
|
||
| public constructor() { | ||
| } | ||
| } | ||
|
|
||
| export namespace FundingInstrument { | ||
| export enum SourceOfFundsEnum { | ||
| Debit = 'DEBIT', | ||
| DepositAccount = 'DEPOSIT_ACCOUNT' | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -22,7 +22,7 @@ export class PlatformPayment { | |||||
| */ | ||||||
| "paymentMerchantReference"?: string; | ||||||
| /** | ||||||
| * Specifies the nature of the transfer. This parameter helps categorize transfers so you can reconcile transactions at a later time, using the Balance Platform Accounting Report for [marketplaces](https://docs.adyen.com/marketplaces/reports-and-fees/balance-platform-accounting-report/) or [platforms](https://docs.adyen.com/platforms/reports-and-fees/balance-platform-accounting-report/). Possible values: * **AcquiringFees**: the acquiring fee (the aggregated amount of interchange and scheme fee) incurred on a transaction. * **AdyenCommission**: the transaction fee due to Adyen under [blended rates](https://www.adyen.com/knowledge-hub/guides/payments-training-guide/get-the-best-from-your-card-processing). * **AdyenFees**: all transaction fees due to Adyen. This is the aggregated amount of Adyen\'s commission and markup. * **AdyenMarkup**: the transaction fee due to Adyen under [Interchange++ pricing](https://www.adyen.com/pricing). * **BalanceAccount**: the amount booked to your user after the deduction of the relevant fees. * **Commission**: your platform\'s or marketplace\'s commission on a transaction. * **DCCPlatformCommission**: the Dynamic Currency Conversion (DCC) fee on a transaction. * **Interchange**: the interchange fee (fee paid to the issuer) incurred on a transaction. * **PaymentFee**: the aggregated amount of all transaction fees. * **Remainder**: the leftover amount after currency conversion. * **SchemeFee**: the scheme fee incurred on a transaction. * **Surcharge**: the surcharge paid by the customer on a transaction. * **Tip**: the tip paid by the customer. * **TopUp**: an incoming transfer to top up your user\'s balance account. * **VAT**: the value-added tax charged on the payment. | ||||||
| * Specifies the nature of the transfer. This parameter helps categorize transfers so you can reconcile transactions at a later time, using the Balance Platform Accounting Report for [marketplaces](https://docs.adyen.com/marketplaces/reports-and-fees/balance-platform-accounting-report/) or [platforms](https://docs.adyen.com/platforms/reports-and-fees/balance-platform-accounting-report/). Possible values: * **AcquiringFees**: The acquiring fee (the aggregated amount of interchange and scheme fee) incurred on a transaction. * **AdyenCommission**: The transaction fee due to Adyen under [blended rates](https://www.adyen.com/knowledge-hub/guides/payments-training-guide/get-the-best-from-your-card-processing). * **AdyenFees**: All transaction fees due to Adyen. This is the aggregated amount of Adyen\'s commission and markup. * **AdyenMarkup**: The transaction fee due to Adyen under [Interchange++ pricing](https://www.adyen.com/pricing). * **BalanceAccount**: The amount booked to your user after the deduction of the relevant fees. * **Commission**: Your platform\'s or marketplace\'s commission on a transaction. * **DCCPlatformCommission**: **deprecated** The Dynamic Currency Conversion (DCC) fee on a transaction. * **DCCMarkup**: The Dynamic Currency Conversion (DCC) fee on a transaction. * **Interchange**: The interchange fee (fee paid to the issuer) incurred on a transaction. * **PaymentFee**: The aggregated amount of all transaction fees. * **Remainder**: The leftover amount after currency conversion. * **SchemeFee**: The scheme fee incurred on a transaction. * **Surcharge**: The surcharge paid by the customer on a transaction. * **Tip**: The tip paid by the customer. * **TopUp**: An incoming transfer to top up your user\'s balance account. * **VAT**: The value-added tax charged on the payment. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To improve clarity around the deprecation, consider updating the descriptions for
Suggested change
|
||||||
| */ | ||||||
| "platformPaymentType"?: PlatformPayment.PlatformPaymentTypeEnum; | ||||||
| /** | ||||||
|
|
@@ -93,6 +93,7 @@ export namespace PlatformPayment { | |||||
| BalanceAccount = 'BalanceAccount', | ||||||
| ChargebackRemainder = 'ChargebackRemainder', | ||||||
| Commission = 'Commission', | ||||||
| DccMarkup = 'DCCMarkup', | ||||||
| DccPlatformCommission = 'DCCPlatformCommission', | ||||||
| Default = 'Default', | ||||||
| Interchange = 'Interchange', | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a JSDoc comment for the
cardIdentificationproperty to improve code clarity and maintainability. All other properties in this class have documentation.