-
Notifications
You must be signed in to change notification settings - Fork 85
[relayedauthorizationwebhooks] Code generation: update services and models #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[relayedauthorizationwebhooks] Code generation: update services and models #1614
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a significant update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR introduces auto-generated TypeScript models and a handler for the relayedauthorizationwebhooks service. The generated code is comprehensive. I've made a few suggestions to improve code quality and maintainability, such as fixing a typo in a comment, improving an error message for better debuggability, and adhering to the common convention of ending files with a newline.
| export * from "./validationResult" | ||
|
|
||
| // serializing and deserializing typed objects | ||
| export * from "./objectSerializer" No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| */ | ||
| "formFactor": Card.FormFactorEnum; | ||
| /** | ||
| * Last last four digits of the card number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return this.getRelayedAuthorisationRequest(); | ||
| } | ||
|
|
||
| throw new Error("Could not parse the json payload: " + this.payload); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message for an unrecognized webhook type is not very helpful for debugging. Concatenating the payload object with a string will result in "[object Object]". Using JSON.stringify will provide the actual payload content in the error message, making it much easier to diagnose issues with incoming webhooks.
| throw new Error("Could not parse the json payload: " + this.payload); | |
| throw new Error("Could not parse the json payload: " + JSON.stringify(this.payload)); |
| return relayedAuthorizationWebhooks.ObjectSerializer.deserialize(this.payload, "RelayedAuthorisationRequest"); | ||
| } | ||
|
|
||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains the automated changes for the
relayedauthorizationwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.