Skip to content

[transferwebhooks] Code generation: update services and models #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdyenAutomationBot wants to merge 1 commit into from
Closed

[transferwebhooks] Code generation: update services and models #1620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/typings/transferWebhooks/transferDataTracking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,7 @@ export type TransferDataTracking = ConfirmationTrackingData | EstimationTracking
*/
export class TransferDataTrackingClass {

static readonly discriminator: string | undefined = "type";
static readonly discriminator: string = "type";

static readonly mapping: {[index: string]: string} | undefined = {
"confirmation": "ConfirmationTrackingData",
"estimation": "EstimationTrackingData",
"internalReview": "InternalReviewTrackingData"
};
static readonly mapping: {[index: string]: string} | undefined = undefined;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Removing the mapping from TransferDataTrackingClass will break the deserialization of the TransferDataTracking union type. The ObjectSerializer relies on this mapping to instantiate the correct class (e.g., ConfirmationTrackingData, EstimationTrackingData) based on the value of the type discriminator field. Without this mapping, the tracking property in webhooks will be deserialized as a plain object instead of an instance of the correct class. This will likely cause the test should correctly deserialize union types in transfer webhooks to fail and lead to runtime errors.

    static readonly mapping: {[index: string]: string} = {
        "confirmation": "ConfirmationTrackingData",
        "estimation": "EstimationTrackingData",
        "internalReview": "InternalReviewTrackingData"
    };

}
Loading