Release v28.3.1

[AdyenAutomationBot]

Merged pull requests to be released:

• Untrusted Actions Versioning #836
• AGENTS.md for contributors #842
• Format UserAgent on API requests #843

Full Changelog: v28.3.0...main

[gemini-code-assist]

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request represents a standard release cycle for the Adyen PHP API library, updating its version to v28.3.1. The core objective is to reflect the integration of recent changes, specifically those from PR #836, by updating the internal version identifiers across the project.

Highlights

• Version Update: The library's version has been incremented from v28.3.0 to v28.3.1.
• Included Changes: This release incorporates the changes introduced in the merged pull request Untrusted Actions Versioning #836.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly bumps the library version to 28.3.1. The changes in VERSION and src/Adyen/Client.php are consistent. However, having the version number in two places creates a maintainability risk. I've left a comment suggesting the addition of a unit test to ensure these two values stay in sync for future releases, which would prevent potential inconsistencies.

[gemini-code-assist]

There's a maintainability risk here. The library version is hardcoded in this file and also in the root VERSION file. This duplication means a version update needs to happen in two places, and it's possible to forget one, leading to inconsistencies.

To mitigate this without a breaking change, I suggest adding a unit test to verify that Client::LIB_VERSION always matches the version in the VERSION file. This will act as a safeguard during future releases.

Here's an example of what you could add to tests/Unit/ClientTest.php:

public function testLibraryVersionMatchesVersionFile(): void
{
    $versionFromFile = trim(file_get_contents(__DIR__ . '/../../VERSION'));
    $this->assertSame($versionFromFile, \Adyen\Client::LIB_VERSION, 'Client::LIB_VERSION should match the VERSION file.');
}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud