Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a standard release cycle for the Adyen PHP API library, updating its version to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly bumps the library version to 28.3.1. The changes in VERSION and src/Adyen/Client.php are consistent. However, having the version number in two places creates a maintainability risk. I've left a comment suggesting the addition of a unit test to ensure these two values stay in sync for future releases, which would prevent potential inconsistencies.
src/Adyen/Client.php
Outdated
| class Client | ||
| { | ||
| const LIB_VERSION = "28.3.0"; | ||
| const LIB_VERSION = "28.3.1"; |
There was a problem hiding this comment.
There's a maintainability risk here. The library version is hardcoded in this file and also in the root VERSION file. This duplication means a version update needs to happen in two places, and it's possible to forget one, leading to inconsistencies.
To mitigate this without a breaking change, I suggest adding a unit test to verify that Client::LIB_VERSION always matches the version in the VERSION file. This will act as a safeguard during future releases.
Here's an example of what you could add to tests/Unit/ClientTest.php:
public function testLibraryVersionMatchesVersionFile(): void
{
$versionFromFile = trim(file_get_contents(__DIR__ . '/../../VERSION'));
$this->assertSame($versionFromFile, \Adyen\Client::LIB_VERSION, 'Client::LIB_VERSION should match the VERSION file.');
}
AdyenAutomationBot
force-pushed
the
promote/main
branch
2 times, most recently
from
deb2670 to
a7adf0b
Compare
AdyenAutomationBot
force-pushed
the
promote/main
branch
12 times, most recently
from
3baae51 to
0497b5d
Compare
AdyenAutomationBot
force-pushed
the
promote/main
branch
6 times, most recently
from
10e397a to
02e2743
Compare
AdyenAutomationBot
force-pushed
the
promote/main
branch
4 times, most recently
from
c3b5fae to
6b16bc2
Compare
AdyenAutomationBot
force-pushed
the
promote/main
branch
2 times, most recently
from
6d56e3f to
5101e1c
Compare
AdyenAutomationBot
force-pushed
the
promote/main
branch
3 times, most recently
from
bd95aab to
2b30688
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AdyenAutomationBot
force-pushed
the
promote/main
branch
from
2b30688 to
6545267
Compare
|
2 participants
Merged pull requests to be released:
Full Changelog: v28.3.0...main