[capital] Code generation: update services and models#876
[capital] Code generation: update services and models#876AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces automated code changes for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR introduces several new data models for the Capital API, including bank account identification types for various locales (AU, BR, CA, CZ, DK, HK, HU, NO), as well as models for actions, amounts, balances, counterparties, disbursements, fees, grants, and repayment information. These models define the structure and properties of data used in the Capital API, enhancing code organization and data handling.
| if ($this->container['accountNumber'] === null) { | ||
| $invalidProperties[] = "'accountNumber' can't be null"; | ||
| } |
There was a problem hiding this comment.
The condition $this->container['accountNumber'] === null checks for strict null comparison. However, the accountNumber property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
| if ($this->container['bsbCode'] === null) { | ||
| $invalidProperties[] = "'bsbCode' can't be null"; | ||
| } |
There was a problem hiding this comment.
The condition $this->container['bsbCode'] === null checks for strict null comparison. However, the bsbCode property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
| if ($this->container['type'] === null) { | ||
| $invalidProperties[] = "'type' can't be null"; | ||
| } |
There was a problem hiding this comment.
The condition $this->container['type'] === null checks for strict null comparison. However, the type property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
| * Validate all the properties in the model | ||
| * return true if all passed | ||
| * |
There was a problem hiding this comment.
The condition $this->container['accountNumber'] === null checks for strict null comparison. However, the accountNumber property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
| * @return bool True if all properties are valid | ||
| */ | ||
| public function valid() |
There was a problem hiding this comment.
The condition $this->container['bankCode'] === null checks for strict null comparison. However, the bankCode property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
| * Validate all the properties in the model | ||
| * return true if all passed | ||
| * |
There was a problem hiding this comment.
The condition $this->container['type'] === null checks for strict null comparison. However, the type property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
The condition $this->container['iban'] === null checks for strict null comparison. However, the iban property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
| * Validate all the properties in the model | ||
| * return true if all passed | ||
| * |
There was a problem hiding this comment.
The condition $this->container['type'] === null checks for strict null comparison. However, the type property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
The condition $this->container['accountNumber'] === null checks for strict null comparison. However, the accountNumber property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
| * Validate all the properties in the model | ||
| * return true if all passed | ||
| * |
There was a problem hiding this comment.
The condition $this->container['type'] === null checks for strict null comparison. However, the type property is defined as string, which cannot be null. This check will always return false. Consider using empty() to check if the string is empty.
AdyenAutomationBot
force-pushed
the
sdk-automation/capital
branch
from
f9da492 to
3bcf72b
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/capital
branch
from
3bcf72b to
f0947f6
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/capital
branch
from
f0947f6 to
3628b74
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/capital
branch
from
3628b74 to
2e4f3f2
Compare
|
1 participant
This PR contains the automated changes for the
capitalservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.