1. OpenAPI generator upgrade: add templates and shared classes#897
1. OpenAPI generator upgrade: add templates and shared classes#897
Conversation
gcatanese
changed the title
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents the first iteration of upgrading the OpenAPI Generator. It introduces new code alongside the old version, which will be refined in subsequent iterations. The changes include adding and customizing Mustache templates, incorporating shared code, generating Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant upgrade to the OpenAPI generator, adding new shared classes like Configuration and BaseService, and generating the BinLookup API client. The changes are extensive and bring in modern PHP features. My review focuses on improving the new shared components and fixing some bugs in the generated code. I've identified a critical issue in the error handling within the new BinLookupApi client, along with some design concerns in the Configuration class and other bugs. The feedback provided aims to enhance the robustness, maintainability, and correctness of the new code.
Note: Security Review did not run due to the size of the PR.
|
1 participant
First iteration of the OpenAPI Generator upgrade:
Configuration,BaseService, etc...)BinlookUpservices and modelsBinlookUpto verify main use cases: initialise objects, send requests, add custom headers, throw exceptions upon4xx/5xxerrorsAt the moment the new code co-exist with the old version, therefore there is a bit of mix of approaches and code, I also had to disable few tests (to verify/refactor later). This will improve as we progress this migration.