Skip to content

Chore/setup nx#1060

Draft
german664 wants to merge 17 commits intodevelopfrom
chore/setup-nx
Draft

Chore/setup nx#1060
german664 wants to merge 17 commits intodevelopfrom
chore/setup-nx

Conversation

@german664
Copy link
Contributor

@german664 german664 commented Mar 24, 2026

Workspace setup (IEX-2463)
• Initialized NX workspace: nx.json, pnpm-workspace.yaml, tsconfig.base.json with @iex/* aliases, .nxignore
• Plugin-based target inference (@nx/vite/plugin, @nx/vitest)
• Shared Vite preset (config/preact-vite-lib.config.ts)
• Sample packages: @iex/lib (wraps root src/), @iex/sample-domain, @iex/publish
• ReportsOverview routed through the full indirection chain: story -> domain/publish -> @iex/lib -> root src/

Validation (IEX-2464)
• Storybook discovers and renders stories from packages//stories/
• SCSS @use 'style' resolves Bento tokens from inside packages via loadPaths
• nx affected correctly propagates through the dependency graph

Publish diff + boundaries (IEX-2465)
• pnpm run publish-diff — builds and compares JS exports, CSS, .d.ts, package.json fields against a checked-in baseline
• pnpm run publish-diff:update — updates baseline for intentional changes
• BOUNDARIES.md — tag taxonomy and import constraint rules
• @nx/enforce-module-boundaries wired at warn level

Tested scenarios

Fixed issue: IEX-2465 IEX-2464 IEX-2463

@german664 german664 self-assigned this Mar 24, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural shift by integrating Nx to manage the project as a monorepo. This change aims to improve code organization, reusability, and build performance by structuring the codebase into distinct packages. The update also cleans up outdated development guides and enhances Storybook's capabilities to better support the new modular structure, ensuring a more robust and maintainable development environment.

Highlights

  • Monorepo Setup with Nx: The project has been refactored into a monorepo structure using Nx, introducing a packages directory for shared libraries and domain-specific components. This includes new Nx configuration files (nx.json, project.json for each package) and a pnpm-workspace.yaml.
  • Scaffolding Documentation Removal: Several outdated scaffolding guides related to external components, stories, and mock data have been removed from the .agents/patterns and .agents/scaffolding directories, streamlining documentation.
  • Storybook Enhancements: Storybook configuration has been updated to support the new monorepo structure, including alias resolution for internal packages and the introduction of global controls for locale and font family, improving testability and presentation.
  • Development Tooling Updates: The Node.js version in GitHub Actions has been pinned to 24.9.0, and Nx-related development dependencies have been added to package.json.
  • Test File Refinements: Previously skipped or commented-out test cases in CalendarInput.test.tsx and useTimezoneAwareDateFormatting.test.ts have been enabled, and references to page object models were removed from testing documentation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/compressed-size.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@german664 german664 changed the base branch from chore/add-skills-folder to chore/add-agentsmd March 24, 2026 15:50
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Nx-based monorepo structure, adding sample shared and domain libraries. It updates the build and configuration files to support Nx, including nx.json, .gitignore, and tsconfig files. Storybook configuration has been refactored to integrate with the new package structure and enhance global controls for locale and font family. Additionally, outdated scaffolding documentation has been removed, and previously disabled test cases have been re-enabled.

Base automatically changed from chore/add-agentsmd to develop March 25, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants