Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant architectural shift by integrating Nx to manage the project as a monorepo. This change aims to improve code organization, reusability, and build performance by structuring the codebase into distinct packages. The update also cleans up outdated development guides and enhances Storybook's capabilities to better support the new modular structure, ensuring a more robust and maintainable development environment. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Nx-based monorepo structure, adding sample shared and domain libraries. It updates the build and configuration files to support Nx, including nx.json, .gitignore, and tsconfig files. Storybook configuration has been refactored to integrate with the new package structure and enhance global controls for locale and font family. Additionally, outdated scaffolding documentation has been removed, and previously disabled test cases have been re-enabled.
…Container renderer
…omponent rendering from packages
…orts root src/, domain publish exposes ReportsOverview
…orce-module-boundaries at warn
a731e0d to
7104457
Compare
Workspace setup (IEX-2463)
• Initialized NX workspace: nx.json, pnpm-workspace.yaml, tsconfig.base.json with @iex/* aliases, .nxignore
• Plugin-based target inference (@nx/vite/plugin, @nx/vitest)
• Shared Vite preset (config/preact-vite-lib.config.ts)
• Sample packages: @iex/lib (wraps root src/), @iex/sample-domain, @iex/publish
• ReportsOverview routed through the full indirection chain: story -> domain/publish -> @iex/lib -> root src/
Validation (IEX-2464)
• Storybook discovers and renders stories from packages//stories/
• SCSS @use 'style' resolves Bento tokens from inside packages via loadPaths
• nx affected correctly propagates through the dependency graph
Publish diff + boundaries (IEX-2465)
• pnpm run publish-diff — builds and compares JS exports, CSS, .d.ts, package.json fields against a checked-in baseline
• pnpm run publish-diff:update — updates baseline for intentional changes
• BOUNDARIES.md — tag taxonomy and import constraint rules
• @nx/enforce-module-boundaries wired at warn level
Tested scenarios
Fixed issue: IEX-2465 IEX-2464 IEX-2463