chore: modernize SDK to Python 3.8+ baseline#421
Conversation
This change aligns the library with modern Python standards by dropping support for legacy Python versions (2.7 and 3.6). Technical Changes: - Updated setup.py to set python_requires='>=3.8' and added classifiers up to Python 3.14. - Introduced PEP 484 Type Hints in AdyenClient and AdyenResult to improve developer experience and IDE support. - Removed legacy __future__ imports and (object) inheritance. - Modernized super() calls to use Python 3 syntax. - Updated setup.py with install_requires and extras_require for idiomatic dependency management (requests, pycurl). - Updated tox.ini and GitHub Actions to test across Python 3.8 through 3.14.
Summary of ChangesHello @thomasc-adyen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Adyen Python SDK by aligning it with current Python standards. It drops support for Python 2.7 and 3.6, establishing Python 3.8 as the new minimum baseline. The changes introduce type hints for improved developer experience, remove outdated language constructs, and update dependency management and testing configurations to reflect the new Python version support. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
There was a problem hiding this comment.
Code Review
This pull request successfully modernizes the SDK to a Python 3.8+ baseline, aligning the library with current Python standards. Key improvements include the removal of legacy __future__ imports and (object) inheritance, modernization of super() calls, and the introduction of PEP 484 type hints in AdyenClient and AdyenResult. Dependency management in setup.py has been updated with python_requires and extras_require, and tox.ini and classifiers reflect the new supported Python versions (3.8-3.14). These changes enhance code clarity, maintainability, and developer experience.



This change aligns the library with modern Python standards by dropping support for legacy Python versions (2.7 and 3.6).
Technical Changes: