[WIP] Card view #787
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| yarn test > /dev/null 2>&1 || yarn test | ||
| yarn lint > /dev/null 2>&1 || yarn lint | ||
| yarn typecheck > /dev/null 2>&1 || yarn typecheck | ||
| swiftformat --lint ios > /dev/null 2>&1 || swiftformat --lint ios | ||
| ktlint "!**node_modules**" > /dev/null 2>&1 || ktlint "!**node_modules**" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| package com.adyenreactnativesdk.component | ||
|
|
||
| import com.adyen.checkout.components.core.action.Action | ||
| import com.adyenreactnativesdk.component.base.BaseModule | ||
| import com.adyenreactnativesdk.component.base.ModuleException | ||
| import com.adyenreactnativesdk.react.ComponentContract | ||
| import com.adyenreactnativesdk.util.ReactNativeJson | ||
| import com.adyenreactnativesdk.util.messaging.MessageBus | ||
| import com.facebook.react.bridge.ReactApplicationContext | ||
| import com.facebook.react.bridge.ReactMethod | ||
| import com.facebook.react.bridge.ReadableMap | ||
| import org.json.JSONException | ||
|
|
||
| class MessageBusModule( | ||
| val context: ReactApplicationContext?, | ||
| val messageBus: MessageBus, | ||
| ) : BaseModule(context) { | ||
| override fun getName(): String = COMPONENT_NAME | ||
|
|
||
| @ReactMethod | ||
| fun addListener(eventName: String?) { | ||
| } | ||
|
|
||
| @ReactMethod | ||
| fun removeListeners(count: Int?) { | ||
| } | ||
|
|
||
| @ReactMethod | ||
| fun hide( | ||
| success: Boolean, | ||
| message: ReadableMap?, | ||
| ) { | ||
| cleanup() | ||
| } | ||
|
|
||
| @ReactMethod | ||
| fun handle(actionMap: ReadableMap?) { | ||
| val name = | ||
| currentComponent ?: return messageBus.sendErrorEvent(ModuleException.NoPaymentRegistered()) | ||
|
|
||
| val component = | ||
| consumers[name] | ||
| ?: return messageBus.sendErrorEvent(ModuleException.NoConsumer(name)) | ||
|
|
||
| try { | ||
| val jsonObject = ReactNativeJson.convertMapToJson(actionMap) | ||
| val action = Action.Companion.SERIALIZER.deserialize(jsonObject) | ||
| component.onAction(action) | ||
| } catch (e: JSONException) { | ||
| messageBus.sendErrorEvent(ModuleException.InvalidAction(e)) | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| private const val TAG = "MessageBusModule" | ||
| private const val COMPONENT_NAME = "AdyenMessageBus" | ||
| var consumers: MutableMap<String, ComponentContract> = mutableMapOf() | ||
| var currentComponent: String? = null | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,15 @@ | ||
| package com.adyenreactnativesdk.component | ||
|
|
||
| import androidx.lifecycle.lifecycleScope | ||
| import com.adyen.checkout.components.core.CheckoutConfiguration | ||
| import com.adyen.checkout.sessions.core.CheckoutSessionProvider | ||
| import com.adyen.checkout.sessions.core.CheckoutSessionResult | ||
| import com.adyen.checkout.sessions.core.SessionModel | ||
| import com.adyen.checkout.sessions.core.SessionSetupResponse | ||
| import com.adyenreactnativesdk.component.base.BaseModule | ||
| import com.adyenreactnativesdk.component.base.ModuleException | ||
| import com.adyenreactnativesdk.configuration.CheckoutConfigurationFactory | ||
| import com.adyenreactnativesdk.util.ReactNativeJson | ||
| import com.facebook.react.bridge.Promise | ||
| import com.facebook.react.bridge.ReactApplicationContext | ||
| import com.facebook.react.bridge.ReactMethod | ||
|
|
@@ -14,42 +21,74 @@ class SessionHelperModule( | |
| context: ReactApplicationContext?, | ||
| ) : BaseModule(context) { | ||
| @ReactMethod | ||
| fun addListener(eventName: String?) { | ||
| // Required for NativeEventEmitter | ||
| } | ||
|
|
||
| @ReactMethod | ||
| fun removeListeners(count: Int?) { | ||
| // Required for NativeEventEmitter | ||
| } | ||
|
|
||
| @ReactMethod | ||
| fun hide( | ||
| success: Boolean, | ||
| message: ReadableMap?, | ||
| ) { // No UI | ||
| cleanup() | ||
| } | ||
|
|
||
| override fun getName(): String = COMPONENT_NAME | ||
|
|
||
| @ReactMethod | ||
| fun createSession( | ||
| sessionModelJSON: ReadableMap, | ||
| configurationJSON: ReadableMap, | ||
| promise: Promise, | ||
| ) { | ||
| appCompatActivity.lifecycleScope.launch(Dispatchers.IO) { | ||
| createSessionAsync(sessionModelJSON, configurationJSON, promise) | ||
| } | ||
| } | ||
|
|
||
| suspend fun createSessionAsync( | ||
| sessionModelJSON: ReadableMap, | ||
| configurationJSON: ReadableMap, | ||
| promise: Promise, | ||
| ) { | ||
| val sessionModel: SessionModel | ||
| val configuration: CheckoutConfiguration | ||
| try { | ||
| sessionModel = parseSessionModel(sessionModelJSON) | ||
| configuration = CheckoutConfigurationFactory.get(configurationJSON) | ||
| } catch (e: java.lang.Exception) { | ||
| promise.reject(ModuleException.SessionError(e)) | ||
| return | ||
| } | ||
|
|
||
| val session = | ||
| when (val result = CheckoutSessionProvider.createSession(sessionModel, configuration)) { | ||
| is CheckoutSessionResult.Success -> { | ||
| result.checkoutSession | ||
| } | ||
|
|
||
| is CheckoutSessionResult.Error -> { | ||
| promise.reject(ModuleException.SessionError(result.exception)) | ||
| return | ||
| } | ||
| } | ||
|
|
||
| val json = SessionSetupResponse.SERIALIZER.serialize(session.sessionSetupResponse) | ||
| val map = ReactNativeJson.convertJsonToMap(json) | ||
| setSession(session) | ||
| promise.resolve(map) | ||
| } | ||
|
|
||
| private fun parseSessionModel(json: ReadableMap): SessionModel { | ||
| val sessionModelJSON = ReactNativeJson.convertMapToJson(json) | ||
| return SessionModel.SERIALIZER.deserialize(sessionModelJSON) | ||
| } | ||
|
|
||
| companion object { | ||
| private const val COMPONENT_NAME = "SessionHelper" | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,13 +8,15 @@ package com.adyenreactnativesdk.component.applepay | |
|
|
||
| import com.adyenreactnativesdk.component.base.BaseModule | ||
| import com.adyenreactnativesdk.component.base.ModuleException | ||
| import com.adyenreactnativesdk.util.messaging.MessageBus | ||
| import com.facebook.react.bridge.Promise | ||
| import com.facebook.react.bridge.ReactApplicationContext | ||
| import com.facebook.react.bridge.ReactMethod | ||
| import com.facebook.react.bridge.ReadableMap | ||
|
|
||
| class ApplePayModuleMock( | ||
| context: ReactApplicationContext?, | ||
| val messageBus: MessageBus, | ||
| ) : BaseModule(context) { | ||
| override fun getName(): String = COMPONENT_NAME | ||
|
|
||
|
|
@@ -27,7 +29,7 @@ class ApplePayModuleMock( | |
| paymentMethodsData: ReadableMap, | ||
| configuration: ReadableMap, | ||
| ) { | ||
| messageBus.sendErrorEvent(ModuleException.NotSupported()) | ||
| } | ||
|
|
||
| @ReactMethod | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current approach of running commands twice on failure (e.g.,
yarn test > /dev/null 2>&1 || yarn test) can be inefficient for long-running tasks like tests. A more efficient pattern would be to capture the command's output and only print it if the command fails, thus avoiding a second execution. For example:This would improve the developer experience by speeding up the pre-commit hook when failures occur.