Example session bug fixes

[descorp]

Changes

• fix example app bug with session fetch error
• fix example app UI bug with too fast navigation
• add tests for AdyenCheckout
• add missing typescript definition to resolve "Cannot find module" error in VS Code

[gemini-code-assist]

Summary of Changes

Hello @descorp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability and developer experience of the Adyen React Native integration. It resolves critical bugs within the example application, specifically addressing session handling and UI navigation issues. Additionally, it introduces comprehensive unit tests for the AdyenCheckout component, ensuring its robustness, and improves TypeScript module resolution for a smoother development workflow.

Highlights

• Example App Bug Fixes: Addressed a session fetch error and a UI bug related to fast navigation in the example application.
• AdyenCheckout Testing: Introduced new unit tests for the AdyenCheckout component to improve code reliability and ensure proper functionality.
• TypeScript Configuration: Added a tsconfig.json file to the example app to resolve module import issues for @adyen/react-native in VS Code.
• Error Code Standardization: Standardized the usage of ErrorCode and ResultCode enums within the SessionsCheckout component and introduced a new ErrorCode.sessionError for consistent error handling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request brings several valuable improvements. The fixes for the session fetch error and the UI navigation bug in the example app are well-implemented. I particularly appreciate the addition of unit tests for AdyenCheckout, which significantly enhances the component's reliability. The refactoring to use enums like ErrorCode and ResultCode instead of magic strings is a great step towards better code maintainability. I've added a couple of suggestions to further improve the robustness of the UI fix and the consistency in the new tests.

[descorp]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces several bug fixes and improvements. The session fetch error is now handled gracefully in the example app, and a UI glitch related to navigation speed has been resolved using InteractionManager. The codebase is also improved by replacing hardcoded strings with enums for error codes and result codes. A tsconfig.json is added to the example app to fix module resolution issues in IDEs. The native iOS code is updated to introduce a new sessionError type and provide more specific error handling during session initialization. Overall, these are solid improvements. I have one suggestion to improve debuggability in the native error handling.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud