CI: Add blank app fixture runner and appium tests#880
CI: Add blank app fixture runner and appium tests#880
Conversation
Summary of ChangesHello @descorp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's testing capabilities by introducing an automated integration testing suite. It sets up a process to build and test the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable set of scripts for creating a test fixture app and running Appium tests, which is a great step towards automated integration testing. My review has identified a few critical and high-severity bugs in the shell scripts related to argument parsing and environment variable handling that would prevent them from executing correctly. I have also included several suggestions to improve the robustness of the tests and the efficiency of the scripts. Addressing these points will ensure the new testing workflow is reliable and maintainable.
26d4e52 to
c6f7eff
Compare
c6f7eff to
1534443
Compare
1534443 to
e449ffb
Compare
e449ffb to
f0a5a1e
Compare
f0a5a1e to
9d210f5
Compare
9d210f5 to
b680499
Compare
b7e3f3a to
6baa0f3
Compare
6baa0f3 to
0580c73
Compare
4eccee4 to
97245f2
Compare
97245f2 to
175f0b7
Compare
8b81a0d to
147ab6b
Compare
9853055 to
1a4c485
Compare
99e133f to
1ac2f57
Compare
|
/gemini review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
d33fd89 to
b190ac3
Compare
b190ac3 to
5ab365a
Compare
6dc80a9 to
d26cf77
Compare
|



Changes
Description
This PR introduces a new End-to-End (E2E) testing infrastructure designed to validate the library against fresh, "blank" React Native and Expo projects. It also optimizes several CI workflows for better performance and observability.
Key Changes
🧪 End-to-End Testing (Appium)
e2e-tests/that usesAppium/WebdriverIOto verify the library loads correctly in newly initialized projects.blank_test.yml, allowing manual or label-triggered testing of specific React Native versions or Expo SDKs.🚀 CI/CD Enhancements
.github/actions/setup-android-emulator) to reduce duplication.run_sonar.ymlto Ubuntu and switched to the npm-based Sonar scanner, significantly reducing execution time.xcodebuildlogs upon test failures.🧹 Code Quality & Cleanup