Skip to content

Comments

CI: Add blank app fixture runner and appium tests#880

Open
descorp wants to merge 54 commits intodevelopfrom
ci-blank-tests
Open

CI: Add blank app fixture runner and appium tests#880
descorp wants to merge 54 commits intodevelopfrom
ci-blank-tests

Conversation

@descorp
Copy link
Contributor

@descorp descorp commented Jan 12, 2026

Changes

Description

This PR introduces a new End-to-End (E2E) testing infrastructure designed to validate the library against fresh, "blank" React Native and Expo projects. It also optimizes several CI workflows for better performance and observability.

Key Changes

🧪 End-to-End Testing (Appium)

  • New E2E Suite: Added a smoke test suite in e2e-tests/ that uses Appium/WebdriverIO to verify the library loads correctly in newly initialized projects.
  • On-Demand Validation: Introduced blank_test.yml, allowing manual or label-triggered testing of specific React Native versions or Expo SDKs.
  • Fixture Generation: Added scripts to autonomously scaffold test applications, inject credentials, and run native builds for both platforms.

🚀 CI/CD Enhancements

  • Composite Actions: Refactored Android emulator setup into a reusable local action (.github/actions/setup-android-emulator) to reduce duplication.
  • Faster Sonar Scans: Migrated run_sonar.yml to Ubuntu and switched to the npm-based Sonar scanner, significantly reducing execution time.
  • Improved Debugging: Added automatic uploads for xcodebuild logs upon test failures.
  • Dynamic Simulator Resolution: Replaced hardcoded iOS device names with a robust resolution script that finds the best available simulator runtime.

🧹 Code Quality & Cleanup

  • Linting: Simplified eslint.config.mjs by removing redundant Prettier rules now handled by .prettierrc.json.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @descorp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's testing capabilities by introducing an automated integration testing suite. It sets up a process to build and test the adyen-react-native SDK within a newly generated, minimal React Native or Expo application. This ensures that the SDK's core functionality and integration remain stable across different environments and React Native versions, preventing regressions and providing a reliable baseline for future development.

Highlights

  • New Integration Testing Workflow: Introduces a comprehensive workflow to test the adyen-react-native SDK's integration with a blank React Native or Expo application.
  • Cross-Platform Appium Tests: Adds scripts/check-app.js which uses WebdriverIO and Appium to perform UI tests on both Android and iOS, verifying core UI elements like the 'Open DropIn' button.
  • Automated Fixture Setup: scripts/fixture_setup.sh automates the creation of new React Native/Expo projects, dependency installation (including adyen-react-native.tgz), and injection of a test App.tsx.
  • Platform-Specific Build Scripts: Includes scripts/fixture_android.sh and scripts/fixture_ios.sh for building the fixture app on their respective platforms, handling platform-specific configurations like MainActivity.kt and CocoaPods.
  • Secure Secret Injection: scripts/inject_secrets.sh ensures that sensitive API keys (ADYEN_CLIENT_KEY and ADYEN_PUBLIC_KEY) are securely injected into the test application from environment variables.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/blank_test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@descorp descorp changed the title Add blank app fixture runner and appium tests CI: Add blank app fixture runner and appium tests Jan 12, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable set of scripts for creating a test fixture app and running Appium tests, which is a great step towards automated integration testing. My review has identified a few critical and high-severity bugs in the shell scripts related to argument parsing and environment variable handling that would prevent them from executing correctly. I have also included several suggestions to improve the robustness of the tests and the efficiency of the scripts. Addressing these points will ensure the new testing workflow is reliable and maintainable.

@descorp descorp force-pushed the ci-blank-tests branch 2 times, most recently from b7e3f3a to 6baa0f3 Compare January 13, 2026 13:28
@descorp descorp added the run-e2e-tests Add to PR so e2e tests are triggered automatically label Feb 12, 2026
@Adyen Adyen deleted a comment from gemini-code-assist bot Feb 20, 2026
@descorp
Copy link
Contributor Author

descorp commented Feb 20, 2026

/gemini review

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@descorp descorp force-pushed the ci-blank-tests branch 2 times, most recently from d33fd89 to b190ac3 Compare February 20, 2026 15:21
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-e2e-tests Add to PR so e2e tests are triggered automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants