Trigger caching #644
Draft
Trigger caching #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently moss runs triggers matching _all_ paths for the new transaction. However, triggers only need to be run when the matching paths _change_ (added / removed). We can diff the previous state w/ the current to produce a list of changed paths to run against trigger matching. This will greatly speedup moss it / rm / sync operations to only run the minimum required triggers on each run.
jplatte
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: This naive implementation doesn't work since it doesn't consider file contents (hash) nor does it consider that tx scoped triggers output their files to the transaction which wont get reused if the trigger is skipped.
A robust solution is needed that caches triggers outputs and links them back into the transaction & "skipping" a trigger would result in us re-using the cached outputs.