Update Verify() with goroutine to speed up the request and some minor changes#121
Open
daison12006013 wants to merge 3 commits intoAfterShip:mainfrom
Open
Update Verify() with goroutine to speed up the request and some minor changes#121daison12006013 wants to merge 3 commits intoAfterShip:mainfrom
daison12006013 wants to merge 3 commits intoAfterShip:mainfrom
Conversation
Member
|
@daison12006013 Generally looks good, thanks for your contribution. It would be great if we could add dedicated methods for those exported fields instead of turning them to a public member directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
getMD5Hash()return orderVerify()to speed up the request.In the meantime, if someone would like to incorporate this on their code, you may copy below
Source Code