Skip to content

Conversation

@Dwij1704
Copy link
Member

@Dwij1704 Dwij1704 commented Jun 2, 2025

📥 Pull Request

📘 Description
Closes #1021

  • Introduced extract_agent_attributes function to gather detailed attributes from agent instances, including name, description, model, instruction, tools, and sub-agents.

  • Enhanced tool attribute setting to include tool description and long-running status, further enriching telemetry data.

  • Added a helper function _is_actually_installed_package to verify if a module is an installed package or a local module, improving accuracy in instrumentation decisions.

  • Refined the _is_package_instrumented function to utilize a more precise check based on registered keys.

  • Updated the _uninstrument_providers function to better manage active instrumentors, ensuring only relevant ones remain active.

  • Enhanced the _should_instrument_package function to incorporate checks for agentic libraries and providers, improving the decision-making process for instrumentation.

  • Improved logging throughout the instrumentation process for better traceability and debugging.

  • Added checks in _perform_instrumentation to ensure proper handling of package names and configurations, enhancing overall robustness.

🧪 Testing
Tested OG crew and a few more indirect import examples
EXAMPLE TO TEST ADK

@Dwij1704 Dwij1704 requested review from areibman and bboynton97 June 2, 2025 23:33
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 50.75758% with 65 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/instrumentation/__init__.py 63.20% 39 Missing ⚠️
agentops/instrumentation/google_adk/patch.py 0.00% 26 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Dwij1704 Dwij1704 requested a review from bboynton97 June 4, 2025 12:07
@Dwij1704 Dwij1704 requested a review from tcdent June 6, 2025 15:50
@Dwij1704 Dwij1704 merged commit 3f71e28 into main Jun 6, 2025
9 of 10 checks passed
@Dwij1704 Dwij1704 deleted the enhance-adk branch June 6, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

continued ADK support improvements

4 participants