Skip to content

terminal logs in jupyter notebooks #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dot-agi merged 11 commits into from
Jun 11, 2025
Merged

terminal logs in jupyter notebooks #1049

dot-agi merged 11 commits into from
Jun 11, 2025

Conversation

@michi-okahata
Copy link
Contributor

@michi-okahata michi-okahata commented Jun 5, 2025

📥 Pull Request

📘 Description
Addresses #989.

Changed init() to set auto_start_session to False if running in a Jupyter Notebook and changed docs.

🧪 Testing
Tested against the OpenAI example in a Jupyter Notebook.

@codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/__init__.py 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@michi-okahata
Copy link
Contributor Author

michi-okahata commented Jun 6, 2025

apologies for the ruff slop

@areibman areibman requested a review from dot-agi June 11, 2025 15:57
dot-agi
dot-agi requested changes Jun 11, 2025
View reviewed changes
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the conflicts? There were changes made to the examples via #1029

@dot-agi dot-agi self-requested a review June 11, 2025 22:25
dot-agi
dot-agi approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @michi-okahata!

@dot-agi dot-agi merged commit a61baa6 into main Jun 11, 2025
10 checks passed
@dot-agi dot-agi deleted the notebook_trace branch June 11, 2025 22:28
@devin-ai-integration devin-ai-integration bot mentioned this pull request Jun 12, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dot-agi dot-agi dot-agi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michi-okahata @dot-agi