Refactor instrumentation modules for improved structure and consistency #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
…molagents_system notebook
dot-agi
requested changes
Jun 18, 2025
Member
dot-agi
left a comment
dot-agi
left a comment
There was a problem hiding this comment.
Some minor changes are requested for now.
I need to test for the final approval.
agentops/instrumentation/agentic/openai_agents/attributes/common.py
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the instrumentation modules for improved structure and consistency. The changes include reorganizing modules under agentic and providers, updating streaming wrappers to consistently pass a streaming context manager, and revising documentation to reflect the new common utilities and configuration patterns.
Reviewed Changes
Copilot reviewed 124 out of 124 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| agentops/instrumentation/agentic/google_adk/instrumentor.py | New instrumentor implementation for Google ADK with patching and metric creation. |
| agentops/instrumentation/agentic/google_adk/init.py | Sets up module-level library information and exports for Google ADK instrumentation. |
| agentops/instrumentation/agentic/crewai/init.py | New lightweight module for CrewAI instrumentor export. |
| agentops/instrumentation/agentic/agno/instrumentor.py | Major refactoring to use streaming_context_manager throughout various wrappers and updating wrapped methods. |
| agentops/instrumentation/agentic/agno/init.py | Updated library information using LibraryInfo for the Agno instrumentor. |
| agentops/instrumentation/agentic/ag2/init.py | New AG2 instrumentation module following updated structure. |
| agentops/instrumentation/ag2/init.py | Removed duplicate or legacy content in favor of the new structure. |
| agentops/instrumentation/init.py | Updated module definitions for provider instrumentors and utilities, adjusting module paths and version utilities. |
| agentops/instrumentation/README.md | Expanded documentation with updated examples and best practices reflecting the refactor. |
Comments suppressed due to low confidence (2)
agentops/instrumentation/init.py:50
- The provider module names have been updated to reflect the new package structure. Please verify that these new module paths align with the intended refactor and that all consumers are updated accordingly.
"module_name": "agentops.instrumentation.providers.openai",
…pdate references across the codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
📘 Description
Briefly describe the changes you've made.
🧪 Testing
Tested with example scripts