Skip to content

Conversation

@fenilfaldu
Copy link
Contributor

@fenilfaldu fenilfaldu commented Jul 23, 2025

📥 Pull Request

📘 Description
Refactor metrics wrapper in instrumentor.py to remove result handling and improve clarity in span attribute setting.

🧪 Testing
Tested the examples

Screenshot 2025-07-23 at 4 57 07 PM Screenshot 2025-07-23 at 4 53 58 PM

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fenilfaldu fenilfaldu requested review from Dwij1704 and dot-agi July 23, 2025 11:30
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@areibman areibman merged commit 593f99e into main Jul 31, 2025
42 of 47 checks passed
@areibman areibman deleted the agno_enhance2 branch July 31, 2025 17:18
fenilfaldu added a commit that referenced this pull request Aug 4, 2025
Refactor metrics wrapper in instrumentor.py

Co-authored-by: Pratyush Shukla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants