Skip to content

Conversation

@dot-agi
Copy link
Member

@dot-agi dot-agi commented Mar 18, 2025

Changelog

  • Modified agentops/__init__.py to ignore top-level import and * import for agentops.legacy
  • Removed track_agent and track_tool from __all__ in agentops/__init__.py since they were imported from agentops.legacy
  • Updated .pre-commit-config.yaml file with the ruff version used and ignoring the examples directory
  • 47 files reformatted, 143 files left unchanged

@dot-agi dot-agi requested a review from areibman March 18, 2025 07:52
@dot-agi dot-agi self-assigned this Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/sdk/core.py 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dot-agi dot-agi requested a review from tcdent March 19, 2025 16:13
@teocns
Copy link
Contributor

teocns commented Mar 19, 2025

Removed track_agent and track_tool from all in agentops/init.py since they were imported from agentops.legacy

This is a breaking change, crewai backwards compatibility will stop working unless something changed on their end

Modified agentops/init.py to ignore top-level import and * import for agentops.legacy
The purpose of legacy is to export legacy functionality

What's the backstory / objective for this PR

@dot-agi
Copy link
Member Author

dot-agi commented Mar 19, 2025

This is a breaking change, crewai backwards compatibility will stop working unless something changed on their end

Only refactors the code a little to comply with linting

What's the backstory / objective for this PR

Read title

@teocns teocns closed this Mar 19, 2025
@dot-agi
Copy link
Member Author

dot-agi commented Mar 19, 2025

@teocns why was this PR closed without providing any information?

@teocns
Copy link
Contributor

teocns commented Mar 19, 2025

Read my comment:

@teocns: This is a breaking change, crewai backwards compatibility will stop working unless something changed on their end

@dot-agi
Copy link
Member Author

dot-agi commented Mar 19, 2025

Read my comment:

@teocns: This is a breaking change, crewai backwards compatibility will stop working unless something changed on their end

Like I said, its only a small refactor, no breaking changes since the namespace contains the functions.

Has been tested with crewai and is working as expected.

@teocns
Copy link
Contributor

teocns commented Mar 19, 2025

Please reopen a PR carefully suppressing critical imports like legacy with # noqa (do not re-order imports like legacy, or even worse delete them). Pay extreme attention to what is being re-ordered: there are times when import order matters and is done strategically.

https://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html

@dot-agi dot-agi deleted the fix/main-formatting branch March 23, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants