Skip to content

Ensure auto started sessions behave properly #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dot-agi merged 4 commits into from
Apr 2, 2025
Merged

Ensure auto started sessions behave properly #899

dot-agi merged 4 commits into from
Apr 2, 2025

Conversation

@tcdent
Copy link
Contributor

@tcdent tcdent commented Mar 27, 2025 •
edited
Loading

  • Unit tests for session manual & auto start
  • Ensure session state is handled properly
  • Verify root spans are being exported correctly

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/__init__.py 75.00% 1 Missing ⚠️
agentops/legacy/__init__.py 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tcdent tcdent linked an issue Mar 27, 2025 that may be closed by this pull request
Ensure session auto-start behaves correctly #898
Closed
@Dwij1704
Copy link
Member

Dwij1704 commented Mar 27, 2025 •
edited
Loading

@tcdent Are you planning to fix #894 with this PR?

@tcdent tcdent linked an issue Mar 27, 2025 that may be closed by this pull request
agentops.init() Not Creating Session Span by Default; start_session() Creates Sibling Span Without Context Propagation #894
Closed
@tcdent tcdent marked this pull request as ready for review March 27, 2025 19:26
@tcdent
Copy link
Contributor Author

tcdent commented Mar 27, 2025

Will address #894 in a separate PR after internal discussion. @the-praxs ready for review.

@tcdent tcdent requested a review from dot-agi March 27, 2025 19:27
dot-agi
dot-agi approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this ok but I am more concerned about thread safety since opentelemtry context management uses threads to pass spans.

@dot-agi dot-agi merged commit 1a2c4ff into main Apr 2, 2025
8 of 10 checks passed
@dot-agi dot-agi deleted the autostart branch April 2, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dot-agi dot-agi dot-agi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@tcdent @Dwij1704 @dot-agi