-
Notifications
You must be signed in to change notification settings - Fork 509
Green checks #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Green checks #972
The head ref may contain hidden characters: "green-checks\u2705"
Conversation
|
Tested all integrations, works |
|
Fix branch name since it has unicde characters that may cause issues |
dot-agi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many files modified in a single PR.
Break by modules, create separate branches and PRs.
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
|
this is a massive pr. in retrospect, i'd love to do linting in an independent PR and tests in another, but no sense separating it now |
bboynton97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR
📥 Pull Request
📘 Description
Briefly describe the changes you've made.
🧪 Testing
Describe the tests you performed to validate your changes.