Skip to content

Conversation

@Dwij1704
Copy link
Member

📥 Pull Request

📘 Description
Briefly describe the changes you've made.

🧪 Testing
Describe the tests you performed to validate your changes.

@Dwij1704
Copy link
Member Author

Tested all integrations, works

@dot-agi
Copy link
Member

dot-agi commented May 13, 2025

Fix branch name since it has unicde characters that may cause issues

Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many files modified in a single PR.

Break by modules, create separate branches and PRs.

@bboynton97
Copy link
Contributor

this is a massive pr. in retrospect, i'd love to do linting in an independent PR and tests in another, but no sense separating it now

Copy link
Contributor

@bboynton97 bboynton97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR

@bboynton97 bboynton97 requested a review from dot-agi May 14, 2025 02:32
@bboynton97 bboynton97 merged commit 691c1fb into main May 14, 2025
9 checks passed
@bboynton97 bboynton97 deleted the green-checks✅ branch May 14, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants