Skip to content

Crewai tags fix in root span #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dot-agi merged 13 commits into from
May 27, 2025
Merged

Crewai tags fix in root span #992

dot-agi merged 13 commits into from
May 27, 2025

Conversation

@fenilfaldu
Copy link
Contributor

@fenilfaldu fenilfaldu commented May 20, 2025

📥 Pull Request

📘 Description
Modified the tag handling logic in the CrewAI instrumentation and also added conditional attribute setting to only include tags when they exist

🧪 Testing
Tested it with tags and without tags as well.

Screenshot 2025-05-21 at 1 52 07 AM

@codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/instrumentation/crewai/instrumentation.py 0.00% 12 Missing ⚠️

📢 Thoughts on this report? Let us know!

@fenilfaldu fenilfaldu requested review from Dwij1704 and dot-agi May 21, 2025 10:34
@bboynton97 bboynton97 self-requested a review May 23, 2025 15:55
@bboynton97 bboynton97 mentioned this pull request May 23, 2025
Closed
bboynton97
bboynton97 previously requested changes May 24, 2025
View reviewed changes
Copy link
Contributor

@bboynton97 bboynton97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tags are already being added other places in the SDK but tbf it did take me a minute to find it :) the frontend only shows tags at agentops.tags

@fenilfaldu
Copy link
Contributor Author

fenilfaldu commented May 26, 2025

Screenshot 2025-05-26 at 11 34 59 PM

:)

@fenilfaldu fenilfaldu requested a review from bboynton97 May 26, 2025 18:44
Dwij1704
Dwij1704 approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@Dwij1704 Dwij1704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work! Good work @fenilfaldu

@Dwij1704 Dwij1704 enabled auto-merge (squash) May 27, 2025 20:44
@Dwij1704 Dwij1704 disabled auto-merge May 27, 2025 20:44
dot-agi
dot-agi approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @fenilfaldu !

@dot-agi dot-agi enabled auto-merge (squash) May 27, 2025 21:11
@dot-agi dot-agi removed the request for review from bboynton97 May 27, 2025 21:11
@dot-agi dot-agi dismissed bboynton97’s stale review May 27, 2025 21:12

SACRIFICES MUST BE MADE FOR THE RELEASE

@dot-agi dot-agi merged commit d7acb59 into main May 27, 2025
9 of 10 checks passed
@dot-agi dot-agi deleted the crewai-tags-fix branch May 27, 2025 21:12
@devin-ai-integration devin-ai-integration bot mentioned this pull request Jun 12, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dot-agi dot-agi dot-agi approved these changes

@Dwij1704 Dwij1704 Dwij1704 approved these changes

@bboynton97 bboynton97 bboynton97 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fenilfaldu @bboynton97 @dot-agi @Dwij1704