fix: Deduplicate broadcast messages in #general channel #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When broadcasts are sent to '*', the backend delivers them to each recipient separately, causing duplicates in the #general channel view. Changes: - Add useBroadcastDedup.ts with deduplication logic - Group broadcasts by sender + content + timestamp (1-second window) - Integrate into MessageList.tsx for #general channel only - Add 14 TDD tests covering all edge cases Broadcasts now appear once per channel instead of once per recipient. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes broadcast message duplication in the #general channel by implementing frontend deduplication logic. When a broadcast is sent to *, the backend delivers it to each recipient separately with unique IDs, causing the same message to appear multiple times in #general. The solution groups broadcasts by sender, content, and timestamp (1-second window) to show each unique broadcast only once.
Key Changes
- Comprehensive deduplication utilities with 14 TDD tests covering all edge cases
- Clean integration in MessageList that only affects #general channel
- Preserves message order and handles mixed broadcast/direct message scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dashboard/react-components/hooks/useBroadcastDedup.ts | New utility module with deduplication logic and React hook wrapper |
| src/dashboard/react-components/hooks/useBroadcastDedup.test.ts | Comprehensive test suite with 14 tests covering all deduplication scenarios |
| src/dashboard/react-components/MessageList.tsx | Integration that applies deduplication only to #general channel messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Wrap deduplication call in useMemo with messages as dependency to prevent unnecessary recalculations when the messages array hasn't changed. This follows the same pattern used by other hooks in the codebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
*now appear once instead of once per recipientProblem
When a broadcast is sent to
*, the backend delivers it to each recipient separately. Each delivery gets a unique ID and is stored separately, causing the same message to appear multiple times in #general (once per recipient).Solution
Frontend deduplication that groups broadcasts by:
from)content)Only the first occurrence of each broadcast is shown.
Changes
useBroadcastDedup.ts: Deduplication utility withgetBroadcastKey()anddeduplicateBroadcasts()useBroadcastDedup.test.ts: 14 comprehensive TDD testsMessageList.tsx: Integration for #general channel only (10 lines)Test plan
🤖 Generated with Claude Code