Skip to content

Integration tests and clean up of zed and parsing#366

Merged
khaliqgant merged 10 commits intomainfrom
test-suite
Feb 4, 2026
Merged

Integration tests and clean up of zed and parsing#366
khaliqgant merged 10 commits intomainfrom
test-suite

Conversation

@khaliqgant
Copy link
Collaborator

@khaliqgant khaliqgant commented Feb 3, 2026

// Step 7: Restore original .mcp.json if needed
console.log('\n7. Cleanup...');
if (originalMcpConfig) {
writeFileSync(mcpConfigPath, originalMcpConfig);

Check failure

Code scanning / CodeQL

Potential file system race condition High test

The file may have changed since it
was checked
.
The file may have changed since it
was checked
.
The file may have changed since it
was checked
.
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View issue and 4 additional flags in Devin Review.

Open in Devin Review

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 4 new potential issues.

View issues and 4 additional flags in Devin Review.

Open in Devin Review

- Fix memory leak: clear seenMessageIds Set in stop() method
- Fix channel message ID collisions: use randomUUID() instead of Date.now()
- Fix default export in utils/index.js: use direct imports instead of await import
- Fix template literal issues in mcp/06-mcp-connect.js
- Disable task-queue.test.js which imports non-existent modules

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View issue and 7 additional flags in Devin Review.

Open in Devin Review

Replace unbounded Set with CircularDedupeCache (capacity 2000) to prevent
memory leak in long-running ACP bridge sessions. The cache automatically
evicts oldest entries when capacity is reached, matching the SDK behavior.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View issues and 11 additional flags in Devin Review.

Open in Devin Review

- Drop threaded messages when target session is closed instead of
  misrouting them to all sessions
- Bound the __pending__ queue to 500 messages to prevent unbounded
  memory growth before first ACP session is created

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 new potential issues.

View issues and 14 additional flags in Devin Review.

Open in Devin Review

…eceive.js

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View issues and 15 additional flags in Devin Review.

Open in Devin Review

- Stream existing buffered messages to user before clearing in bridgeToRelay()
  to prevent pending messages from being discarded
- Remove duplicate __pending__ drain from prompt() to avoid race conditions
  in multi-session scenarios (e.g., multiple Zed windows)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View issue and 26 additional flags in Devin Review.

Open in Devin Review

Track closed session IDs separately so we can distinguish between:
- Threads that match closed ACP sessions (should be dropped)
- Arbitrary thread names like "code-review" (should be broadcast)

This prevents silently dropping legitimate threaded messages that
use relay's general thread feature rather than ACP session IDs.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@khaliqgant khaliqgant merged commit a658465 into main Feb 4, 2026
31 of 32 checks passed
@khaliqgant khaliqgant deleted the test-suite branch February 4, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant