fix: add ping/pong keepalive to main and bridge WebSockets #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main dashboard WebSocket (/ws) and bridge WebSocket (/ws/bridge) were missing ping/pong keepalive mechanisms that prevent TCP/proxy timeouts from killing idle connections. The logs and presence WebSocket endpoints already had 30-second ping intervals, but the main dashboard connections did not. This caused workspace instances to experience WebSocket disconnections when: - TCP idle timeouts kicked in (typically 60-120 seconds) - Load balancers/proxies dropped idle connections (30-60 seconds) - Cloud providers (Fly, Railway) enforced connection timeouts Added: - 30-second ping interval for main dashboard WebSocket - 30-second ping interval for bridge WebSocket - Proper cleanup of intervals on server close - Graceful close (code 1000) for unresponsive clients
For completeness, added 30-second ping/pong keepalive to the local daemon WebSocket servers: - daemon/api.ts: Daemon API WebSocket for dashboard communication - daemon/orchestrator.ts: Orchestrator WebSocket for multi-workspace These are local (localhost) connections so less prone to proxy timeouts, but adding keepalive ensures consistent behavior across all WebSocket endpoints. Changes per file: - Add clientAlive WeakMap and pingInterval properties - Setup 30-second ping interval in start() - Clean up interval in stop() - Handle pong responses in connection handler - Mark clients as alive on connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main dashboard WebSocket (/ws) and bridge WebSocket (/ws/bridge)
were missing ping/pong keepalive mechanisms that prevent TCP/proxy
timeouts from killing idle connections.
The logs and presence WebSocket endpoints already had 30-second ping
intervals, but the main dashboard connections did not. This caused
workspace instances to experience WebSocket disconnections when:
Added: