Skip to content

[Frontend / chore] Add unhandledrejection event handler to suppress route cancellation errors in useBlockNavigation #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ardaerzin wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Frontend / chore] Add unhandledrejection event handler to suppress route cancellation errors in useBlockNavigation #3148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion web/oss/src/hooks/useBlockNavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ const useBlockNavigation = (
}, [_shouldAlert])

useEffect(() => {
// Handle unhandled promise rejections for our intentional route cancellation
const handleUnhandledRejection = (event: PromiseRejectionEvent) => {
if (event.reason === "cancelRouteChange") {
event.preventDefault()
}
}

window.addEventListener("unhandledrejection", handleUnhandledRejection)

const handler = (newRoute: string) => {
if (opened.current || !blocking.current) return

Expand Down Expand Up @@ -84,13 +93,15 @@ const useBlockNavigation = (
cancellable: false,
})

//block NextJS navigation until user confirms or cancels
// Block NextJS navigation until user confirms or cancels
Router.events.emit("routeChangeError")
throw "cancelRouteChange"
}

Router.events.on("routeChangeStart", handler)
return () => {
window.removeEventListener("beforeunload", beforeUnloadHandler)
window.removeEventListener("unhandledrejection", handleUnhandledRejection)
Router.events.off("routeChangeStart", handler)
}
}, [])
Expand Down