Skip to content

fix(frontend): Stop polling for human evaluation runs #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bekossy wants to merge 1 commit into from
+6 −0
Closed

fix(frontend): Stop polling for human evaluation runs #3429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions web/oss/src/components/EvalRunDetails/atoms/table/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {atomWithQuery} from "jotai-tanstack-query"

import axios from "@/oss/lib/api/assets/axiosConfig"
import {buildRunIndex} from "@/oss/lib/evaluations/buildRunIndex"
import {deriveEvaluationKind} from "@/oss/lib/evaluations/utils/evaluationKind"
import {snakeToCamelCaseKeys} from "@/oss/lib/helpers/casing"
import {
getPreviewRunBatcher,
Expand Down Expand Up @@ -321,6 +322,10 @@ export const evaluationRunQueryAtomFamily = atomFamily((runId: string | null) =>
refetchInterval: (query) => {
const status =
query.state.data?.rawRun?.status ?? query.state.data?.camelRun?.status
const kind = deriveEvaluationKind(
query.state.data?.rawRun ?? query.state.data?.camelRun ?? null,
)
if (kind === "human") return false
return isTerminalStatus(status) ? false : 5000
},
queryFn: async () => {
Expand Down
1 change: 1 addition & 0 deletions web/oss/src/components/EvaluationRunsTablePOC/hooks/useEvaluationRunsPolling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const POLLING_INTERVAL_MS = 5_000
*/
const isRowInProgress = (row: EvaluationRunTableRow): boolean => {
if (row.__isSkeleton) return false
if (row.evaluationKind === "human") return false
const status = row.status
if (!status) return false
return IN_PROGRESS_STATUSES.has(status)
Expand Down