fix(api): resolve OpenAPI spec generation issues for Fern SDK #3441
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add include_in_schema=False to deprecated /preview/tracing router to prevent duplicate type declarations - Add explicit operation_id to simple evaluations start endpoint to prevent collision with legacy evaluation endpoint These changes fix issues that cause Fern SDK generation to fail.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
bot
added
the
size:XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/preview/tracing/*routes from OpenAPI schema to prevent duplicate type declarationsoperation_idto simple evaluations start endpoint to prevent collision with legacy evaluation endpointChanges
api/entrypoints/routers.py: Added
include_in_schema=Falseto the deprecated tracing router mount. This keeps the deprecated endpoints functional for backward compatibility while removing them from the OpenAPI spec.api/oss/src/apis/fastapi/evaluations/router.py: Added
operation_id="start_simple_evaluation"to the/{evaluation_id}/startroute to avoid collision with the legacystart_evaluationoperationId.Why
These changes fix issues that cause Fern SDK generation to fail:
Testing