Skip to content

[feat] Add embeds#3816

Open
jp-agenta wants to merge 20 commits intorelease/v0.89.0from
feat/add-embeds
Open

[feat] Add embeds#3816
jp-agenta wants to merge 20 commits intorelease/v0.89.0from
feat/add-embeds

Conversation

@jp-agenta
Copy link
Member

@jp-agenta jp-agenta commented Feb 24, 2026

@vercel
Copy link

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Mar 4, 2026 1:19pm

Request Review

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature labels Feb 24, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

Railway Preview Environment

Image tag pr-3816-be06e71
Status Failed
Logs View workflow run

Updated at 2026-03-04T13:29:32.049Z

@mmabrouk
Copy link
Member

mmabrouk commented Feb 24, 2026

Run failing

cannot import name 'Selector' from 'agenta.sdk.models.shared' (/opt/venv/lib/python3.11/site-packages/agenta/sdk/models/shared.py)

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@junaway
Copy link
Contributor

junaway commented Feb 27, 2026

@mmabrouk, the import issue looks like a Railway issue: in preview environments, the local sdk must be injected in place of the pip package.

@junaway junaway changed the base branch from main to release/v0.87.3 March 2, 2026 23:54

This comment was marked as resolved.

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 8 additional findings in Devin Review.

Open in Devin Review

@junaway junaway changed the base branch from release/v0.87.3 to release/v0.89.0 March 3, 2026 14:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 53 out of 55 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

web/oss/src/components/EvalRunDetails/atoms/table/run.ts:62

  • payload is initialized with { resolve: true }, so Object.keys(payload).length is always non-zero and this helper will never return null once an evaluator ref exists. If the intent is to return null when no reference fields are present, consider checking for reference keys explicitly (excluding resolve) or removing the redundant length check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants