fix: enable memory controller legacy fallback for kelvin-host in release builds#31
Draft
fix: enable memory controller legacy fallback for kelvin-host in release builds#31
Conversation
…cripts Co-authored-by: willsarg <12886992+willsarg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [BUG] Fix memory controller fallback disabled issue
fix: enable memory controller legacy fallback for kelvin-host in release builds
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh users running the release binary with no memory signing keys configured hit a hard error because
kelvin-hostwas compiled withmemory_rpcactive but withoutmemory_legacy_fallback, leaving no recovery path when RPC connection/validation fails.Root Cause
The release build compiles all binaries in a single
cargo buildinvocation:Cargo's feature unification propagates
kelvin-sdk/memory_rpc(pulled in viakelvin-gateway) tokelvin-hostsince both share the samekelvin-sdkdep.memory_legacy_fallbackwas never added, so the hard-error branch fired unconditionally on any RPC failure:Changes
scripts/package-unix-release.sh— addkelvin-host/memory_legacy_fallbackto--featuresscripts/package-windows-release.ps1— sameWith this, unconfigured or unavailable memory controllers degrade gracefully to in-process memory rather than aborting.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.