Skip to content

Fix broken test and start scripts #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
congzhou09 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix broken test and start scripts #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ const {
RtcTokenBuilder,
RtcRole,
RtmTokenBuilder,
RtmRole,
} = require('agora-access-token');
} = require('agora-token');

// Load environment variables from .env file
dotenv.config();
Expand Down Expand Up @@ -117,8 +116,6 @@ const generateRTMToken = (req, resp) => {
if (!uid || uid === '') {
return resp.status(400).json({ error: 'uid is required' });
}
// get role
let role = RtmRole.Rtm_User;
// get the expire time
let expireTime = req.query.expiry;
if (!expireTime || expireTime === '') {
Expand All @@ -130,12 +127,11 @@ const generateRTMToken = (req, resp) => {
const currentTime = Math.floor(Date.now() / 1000);
const privilegeExpireTime = currentTime + expireTime;
// build the token
console.log(APP_ID, APP_CERTIFICATE, uid, role, privilegeExpireTime);
console.log(APP_ID, APP_CERTIFICATE, uid, privilegeExpireTime);
const token = RtmTokenBuilder.buildToken(
APP_ID,
APP_CERTIFICATE,
uid,
role,
privilegeExpireTime
);
// return the token
Expand Down Expand Up @@ -195,7 +191,6 @@ const generateRTEToken = (req, resp) => {
APP_ID,
APP_CERTIFICATE,
uid,
role,
privilegeExpireTime
);
// return the token
Expand Down
13 changes: 6 additions & 7 deletions index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const {
RtcRole,
RtmTokenBuilder,
RtmRole,
} = require('agora-access-token');
} = require('agora-token');

// Mock environment variables
process.env.APP_ID = 'test-app-id';
Expand Down Expand Up @@ -43,8 +43,8 @@ describe('Token Generation API', () => {
it('should return error for missing channel', async () => {
const response = await request(app).get('/rtc//publisher/uid/1234');

expect(response.status).toBe(400);
expect(response.body).toEqual({ error: 'channel is required' });
// '/rtc//publisher/uid/1234' does not match '/rtc/:channel/:role/:tokentype/:uid'
expect(response.status).toBe(404);
});

// Test error handling for invalid role parameter
Expand Down Expand Up @@ -75,8 +75,8 @@ describe('Token Generation API', () => {
it('should return error for missing uid', async () => {
const response = await request(app).get('/rtm/');

expect(response.status).toBe(400);
expect(response.body).toEqual({ error: 'uid is required' });
// '/rtm/' does not match '/rtm/:uid/'
expect(response.status).toBe(404);
});
});

Expand All @@ -99,8 +99,7 @@ describe('Token Generation API', () => {
it('should return error for missing channel', async () => {
const response = await request(app).get('/rte//publisher/uid/1234');

expect(response.status).toBe(400);
expect(response.body).toEqual({ error: 'channel is required' });
expect(response.status).toBe(404);
});

// Test error handling for invalid role parameter
Expand Down