Skip to content

Fix errorStyle has no effect for DropdownButtonFormField2 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AhmedLSayed9 merged 1 commit into from
Mar 7, 2025
Merged

Fix errorStyle has no effect for DropdownButtonFormField2 #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/dropdown_button2/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## UNRELEASED

- Fix errorStyle has no effect for DropdownButtonFormField2, closes #327.

## 3.0.0-beta.21

- Fix menu limits when using searchable dropdown with separators, closes #214.
Expand Down
2 changes: 2 additions & 0 deletions packages/dropdown_button2/lib/src/dropdown_button2.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,7 @@ class DropdownButtonFormField2<T> extends FormField<T> {
error: effectiveDecoration.error,
errorText:
field.errorText ?? effectiveDecoration.errorText,
errorStyle: effectiveDecoration.errorStyle,
//helper: effectiveDecoration.helper,
helperText: effectiveDecoration.helperText,
),
Expand Down Expand Up @@ -1057,6 +1058,7 @@ class DropdownButtonFormField2<T> extends FormField<T> {
.updateSurroundingElements(
error: null,
errorText: null,
errorStyle: null,
//helper: null,
helperText: null,
)
Expand Down
2 changes: 2 additions & 0 deletions packages/dropdown_button2/lib/src/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ extension _InputDecorationExtension on InputDecoration {
InputDecoration updateSurroundingElements({
required Widget? error,
required String? errorText,
required TextStyle? errorStyle,
// TODO(Ahmed): Add this when it's supported by the min version of the package [Flutter>=3.22.0].
// required Widget? helper,
required String? helperText,
}) {
return InputDecoration(
Expand Down