Skip to content

feat(opentelemetry): add space id attribute to tracing #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ahoo-Wang merged 2 commits into from
Feb 4, 2026
Merged

feat(opentelemetry): add space id attribute to tracing #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f343c52
feat(opentelemetry): add space id attribute to tracing
Ahoo-Wang Feb 4, 2026
4dc6fff
chore(release): bump version to 3.3.1
Ahoo-Wang Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cosec-opentelemetry/src/main/kotlin/me/ahoo/cosec/opentelemetry/CoSecInstrumenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,11 @@ object CoSecAttributesExtractor : AttributesExtractor<SecurityContext, Authorize
private val USER_ID_ATTRIBUTE_KEY = stringKey("user.id")
private val USER_ROLES_ATTRIBUTE_KEY = stringArrayKey("user.roles")
private const val COSEC_TENANT_ID_KEY = CoSec.COSEC_PREFIX + "tenant_id"
private const val COSEC_SPACE_ID_KEY = CoSec.COSEC_PREFIX + "space_id"
private const val COSEC_APP_ID_KEY = CoSec.COSEC_PREFIX + "app_id"
private const val COSEC_REQUEST_ID_KEY = CoSec.COSEC_PREFIX + "request_id"
private val COSEC_TENANT_ID_ATTRIBUTE_KEY = stringKey(COSEC_TENANT_ID_KEY)
private val COSEC_SPACE_ID_ATTRIBUTE_KEY = stringKey(COSEC_SPACE_ID_KEY)
private val COSEC_APP_ID_ATTRIBUTE_KEY = stringKey(COSEC_APP_ID_KEY)
private val COSEC_DEVICE_ID_ATTRIBUTE_KEY = stringKey("device.id")
private val COSEC_REQUEST_ID_ATTRIBUTE_KEY = stringKey(COSEC_REQUEST_ID_KEY)
Expand Down Expand Up @@ -112,6 +114,10 @@ object CoSecAttributesExtractor : AttributesExtractor<SecurityContext, Authorize
if (requestId.isNotBlank()) {
attributes.put(COSEC_REQUEST_ID_ATTRIBUTE_KEY, requestId)
}
val spaceId = cosecRequest.spaceId
if (spaceId.isNotBlank()) {
attributes.put(COSEC_SPACE_ID_ATTRIBUTE_KEY, spaceId)
}
}
val securityContext = request
val principal = securityContext.principal
Expand Down
3 changes: 3 additions & 0 deletions ...opentelemetry/src/test/kotlin/me/ahoo/cosec/opentelemetry/CoSecAttributesExtractorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ class CoSecAttributesExtractorTest {
every { appId } returns "appId"
every { deviceId } returns "deviceId"
every { requestId } returns "requestId"
every { spaceId } returns "spaceId"
}
val verifyContext = mockk<PolicyVerifyContext> {
every { policy.id } returns "policyId"
Expand Down Expand Up @@ -86,6 +87,7 @@ class CoSecAttributesExtractorTest {
every { appId } returns "appId"
every { deviceId } returns "deviceId"
every { requestId } returns "requestId"
every { spaceId } returns "spaceId"
}
val verifyContext = mockk<RoleVerifyContext> {
every { roleId } returns "roleId"
Expand Down Expand Up @@ -113,6 +115,7 @@ class CoSecAttributesExtractorTest {
every { appId } returns ""
every { deviceId } returns ""
every { requestId } returns ""
every { spaceId } returns ""
}
val securityContext = SimpleSecurityContext.anonymous()
securityContext.setRequest(request)
Expand Down
1 change: 1 addition & 0 deletions cosec-opentelemetry/src/test/kotlin/me/ahoo/cosec/opentelemetry/TracingAuthorizationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ class TracingAuthorizationTest {
every { appId } returns "appId"
every { deviceId } returns "deviceId"
every { requestId } returns "requestId"
every { spaceId } returns "spaceId"
}
val verifyContext = mockk<RoleVerifyContext> {
every { roleId } returns "roleId"
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# limitations under the License.
#
group=me.ahoo.cosec
version=3.3.0
version=3.3.1
description=RBAC-based And Policy-based Multi-Tenant Reactive Security Framework.
website=https://github.com/Ahoo-Wang/CoSec
issues=https://github.com/Ahoo-Wang/CoSec/issues
Expand Down
Loading