Skip to content

build(deps): add kotlin-logging dependency#595

Merged
Ahoo-Wang merged 1 commit intomainfrom
kotlin-logging
Mar 22, 2025
Merged

build(deps): add kotlin-logging dependency#595
Ahoo-Wang merged 1 commit intomainfrom
kotlin-logging

Conversation

@Ahoo-Wang
Copy link
Owner

  • Add kotlin-logging to cosky-core, cosky-discovery, and cosky-config modules
  • Replace slf4j with kotlin-logging for better Kotlin integration
  • Update logging statements across multiple files to use KotlinLogging

- Add kotlin-logging to cosky-core, cosky-discovery, and cosky-config modules
- Replace slf4j with kotlin-logging for better Kotlin integration
- Update logging statements across multiple files to use KotlinLogging
@Ahoo-Wang Ahoo-Wang added the dependency Upgrade dependencies label Mar 22, 2025
@codecov
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 71.29630% with 31 lines in your changes missing coverage. Please review.

Project coverage is 77.11%. Comparing base (dd5dfb8) to head (f38cf24).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...very/loadbalancer/ArrayWeightRandomLoadBalancer.kt 30.00% 6 Missing and 1 partial ⚠️
...iscovery/redis/ConsistencyRedisServiceDiscovery.kt 53.84% 6 Missing ⚠️
...overy/loadbalancer/TreeWeightRandomLoadBalancer.kt 0.00% 5 Missing ⚠️
...in/me/ahoo/cosky/discovery/RenewInstanceService.kt 63.63% 4 Missing ⚠️
...ery/loadbalancer/BinaryWeightRandomLoadBalancer.kt 50.00% 3 Missing ⚠️
...hoo/cosky/discovery/redis/RedisServiceStatistic.kt 60.00% 2 Missing ⚠️
...onfig/spring/cloud/refresh/CoSkyConfigRefresher.kt 33.33% 2 Missing ⚠️
.../registry/CoSkyAutoServiceRegistrationOfNoneWeb.kt 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #595      +/-   ##
============================================
+ Coverage     74.75%   77.11%   +2.35%     
- Complexity      361      394      +33     
============================================
  Files            69       69              
  Lines          1347     1311      -36     
  Branches        142      117      -25     
============================================
+ Hits           1007     1011       +4     
+ Misses          203      190      -13     
+ Partials        137      110      -27     
Flag Coverage Δ
unittests 77.11% <71.29%> (+2.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ahoo-Wang Ahoo-Wang merged commit f3acde1 into main Mar 22, 2025
12 checks passed
@Ahoo-Wang Ahoo-Wang deleted the kotlin-logging branch March 22, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency Upgrade dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant