fix: handle errors in /help command gracefully (#4992)#4994
Open
jjjojoj wants to merge 1 commit intoAider-AI:mainfrom
Open
fix: handle errors in /help command gracefully (#4992)#4994jjjojoj wants to merge 1 commit intoAider-AI:mainfrom
jjjojoj wants to merge 1 commit intoAider-AI:mainfrom
Conversation
The /help command could crash with litellm.BadRequestError when no provider is set, or RuntimeError when embedding model fails to load. Wrap Help() init, Coder.create(), and coder.run() in try-except to show user-friendly error messages instead of crashing.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4992
The
/helpcommand could crash withlitellm.BadRequestErrorwhen no LLM provider is set, orRuntimeErrorwhen the embedding model fails to load.Changes
Help()initialization in try-except to catchRuntimeErrorand other exceptionsCoder.create()in try-except to handle LLM provider errorscoder.run()in try-except to handle runtime errorsTest plan
/help <question>without a configured LLM provider - should show error message instead of crashing/helpwhen network is unavailable (embedding model download fails) - should show error message instead of crashing