Skip to content

Support $$ as placeholder name in SQLite dialect #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parent: Apply changes from v0.53.0
wants to merge 3 commits into from
Closed

Support $$ as placeholder name in SQLite dialect #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c92f2fa
Support $$ as placeholder name in SQLite dialect
hansott Dec 26, 2024
d2d9c40
Don't support quoted strings for SQLite
hansott Dec 26, 2024
296d3d4
Merge branch 'update' of github.com:AikidoSec/datafusion-sqlparser-rs…
hansott Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/tokenizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ use sqlparser_derive::{Visit, VisitMut};
use crate::ast::DollarQuotedString;
use crate::dialect::Dialect;
use crate::dialect::{
BigQueryDialect, DuckDbDialect, GenericDialect, MySqlDialect, PostgreSqlDialect,
BigQueryDialect, DuckDbDialect, GenericDialect, MySqlDialect, PostgreSqlDialect, SQLiteDialect,
SnowflakeDialect,
};
use crate::keywords::{Keyword, ALL_KEYWORDS, ALL_KEYWORDS_INDEX};
Expand Down Expand Up @@ -1281,6 +1281,12 @@ impl<'a> Tokenizer<'a> {
if let Some('$') = chars.peek() {
chars.next();

// Treat `$$` as a placeholder for SQLite
// See https://www.sqlite.org/lang_expr.html#varparam
if self.dialect.is::<SQLiteDialect>() {
return Ok(Token::Placeholder("$$".to_string()));
}

let mut is_terminated = false;
let mut prev: Option<char> = None;

Expand Down
9 changes: 9 additions & 0 deletions tests/sqlparser_sqlite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,15 @@ fn test_dollar_identifier_as_placeholder() {
}
_ => unreachable!(),
}

match sqlite().verified_expr("id = $$") {
Expr::BinaryOp { op, left, right } => {
assert_eq!(op, BinaryOperator::Eq);
assert_eq!(left, Box::new(Expr::Identifier(Ident::new("id"))));
assert_eq!(right, Box::new(Expr::Value(Placeholder("$$".to_string()))));
}
_ => unreachable!(),
}
}

fn sqlite() -> TestedDialects {
Expand Down