Merged
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
hansott
reviewed
Jan 27, 2025
hansott
reviewed
Jan 27, 2025
library/agent/Agent.ts
Outdated
| this.api.report(this.token, attack, this.timeoutInMS).catch((err) => { | ||
| console.error( | ||
| `Aikido: Failed to report attack event to Aikido platform: ${err.message}` | ||
| ); |
Member
There was a problem hiding this comment.
What if token was rotated when the app is running? Can we also catch the invalid_token error?
hansott
reviewed
Jan 27, 2025
library/agent/Agent.ts
Outdated
|
|
||
| if (!response.success && response.error === "invalid_token") { | ||
| console.error( | ||
| "Aikido: Unable to access the Aikido platform, please check your token." |
Member
There was a problem hiding this comment.
Let's extract a function to check response?
Co-authored-by: Hans Ott <hansott@hotmail.be>
hansott
approved these changes
Jan 27, 2025
hansott
changed the title
hansott
added a commit
that referenced
this pull request
Jan 27, 2025
* 'main' of github.com:AikidoSec/node-RASP: (209 commits) Only install library deps when publishing to npm (#511) Show connection failures on startup (#510) Fix duplicate clickhouse Run tests for supported dialects Update Zen internals to v0.1.36 Only capture hostname if the port is known Fix Heartbeat event types Add test with invalid json fix: Do not override existing body Prevent double wrapping Fix linting Wrap Hono request body parsing methods Improve failing unit test Improve code coverage Fix linting Support fetch(new Request(...)) Create failing unit test chore: added reference to env vars Use separate table for postgres sink tests Upgrade Zen internals to v0.1.35 ...
hansott
added a commit
that referenced
this pull request
Feb 5, 2025
* 'main' of github.com:AikidoSec/node-RASP: (31 commits) Update Zen internals to v0.1.37 Fix timestamp in mock server (#517) Remove unused methods (#516) Set timeout on workflows Use 401 Increase timeout to 3s and append error message to log Check route level access before we check if IP is in bypass list Only install library deps when publishing to npm (#511) Show connection failures on startup (#510) Revert "Add failing test for route level allowed IPs" Fix duplicate clickhouse Run tests for supported dialects Update Zen internals to v0.1.36 Add failing test for route level allowed IPs Only capture hostname if the port is known Fix Heartbeat event types Remove comment Force build of docker compose Add end2end test for bypass IP in blocklist Fix lint ...
hansott
added a commit
that referenced
this pull request
Feb 7, 2025
* 'main' of github.com:AikidoSec/node-RASP: (38 commits) Speed up unit tests (#497) Move outside if Keep original code Use Number.isInteger(...) Update Zen internals to v0.1.37 Fix timestamp in mock server (#517) Remove unused methods (#516) Update readme Set timeout on workflows Use 401 Increase timeout to 3s and append error message to log Check route level access before we check if IP is in bypass list Only install library deps when publishing to npm (#511) Show connection failures on startup (#510) Revert "Add failing test for route level allowed IPs" Fix duplicate clickhouse Run tests for supported dialects Update Zen internals to v0.1.36 Add failing test for route level allowed IPs Only capture hostname if the port is known ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #435