-
Notifications
You must be signed in to change notification settings - Fork 40
Improve isPrivateIP function #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b6637aa
Add comments and missing ipv6 ranges
timokoessler 5ac7a4b
Fix IPv4-mapped address support
timokoessler 0bd949d
Fix comment
timokoessler 9378eb4
Add comment, remove ::ffff:0:0
timokoessler 4051df4
Update library/helpers/mapIPv4ToIPv6.ts
timokoessler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import * as t from "tap"; | ||
| import mapIPv4ToIPv6 from "./mapIPv4ToIPv6"; | ||
|
|
||
| t.test("it works", async (t) => { | ||
| t.equal(mapIPv4ToIPv6("127.0.0.0"), "::ffff:127.0.0.0/128"); | ||
| t.equal(mapIPv4ToIPv6("127.0.0.0/8"), "::ffff:127.0.0.0/104"); | ||
| t.equal(mapIPv4ToIPv6("10.0.0.0"), "::ffff:10.0.0.0/128"); | ||
| t.equal(mapIPv4ToIPv6("10.0.0.0/8"), "::ffff:10.0.0.0/104"); | ||
| t.equal(mapIPv4ToIPv6("10.0.0.1"), "::ffff:10.0.0.1/128"); | ||
| t.equal(mapIPv4ToIPv6("10.0.0.1/8"), "::ffff:10.0.0.1/104"); | ||
| t.equal(mapIPv4ToIPv6("192.168.0.0/16"), "::ffff:192.168.0.0/112"); | ||
| t.equal(mapIPv4ToIPv6("172.16.0.0/12"), "::ffff:172.16.0.0/108"); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /** | ||
| * Maps an IPv4 address to an IPv6 address. | ||
| * e.g. 127.0.0.0/8 -> ::ffff:127.0.0.0/104 | ||
| */ | ||
| export default function mapIPv4ToIPv6(ip: string): string { | ||
| if (!ip.includes("/")) { | ||
| // No CIDR suffix, assume /32 | ||
| return `::ffff:${ip}/128`; | ||
| } | ||
|
|
||
| const parts = ip.split("/"); | ||
| const suffix = Number.parseInt(parts[1], 10); | ||
| // we add 96 to the suffix, since ::ffff: already is 96 bits, so the 32 remaining bits are decided by the IPv4 address | ||
| return `::ffff:${parts[0]}/${suffix + 96}`; | ||
timokoessler marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.