Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [18.x]
node-version: [20.x, 24.x]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -48,10 +48,15 @@ jobs:
- name: Run shell injection Benchmark
run: cd benchmarks/shell-injection && node benchmark.js
- name: Run Hono with Postgres Benchmark
# Skip on Node 24.x due to a bug: https://github.com/honojs/node-server/issues/240
if: matrix.node-version != '24.x'
run: cd benchmarks/hono-pg && node benchmark.js
- name: Run API Discovery Benchmark
run: cd benchmarks/api-discovery && node benchmark.js
- name: Run Express Benchmark
# Skip on Node 24.x because benchmark currently fails.
# Big performance improve in comparison to older Node.js versions, but higher difference between usage with and without Zen
if: matrix.node-version != '24.x'
run: cd benchmarks/express && node benchmark.js
- name: Check Rate Limiter memory usage
run: cd benchmarks/rate-limiting && node --expose-gc memory.js
2 changes: 1 addition & 1 deletion .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16.x, 18.x, 20.x, 22.x, 23.x]
node-version: [16.x, 18.x, 20.x, 22.x, 24.x]
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion end2end/server/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:22
FROM node:22-slim

WORKDIR /app

Expand Down
14 changes: 14 additions & 0 deletions library/agent/hooks/isBuiltinModule.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as t from "tap";
import { isBuiltinModule } from "./isBuiltinModule";
import { getMajorNodeVersion } from "../../helpers/getNodeVersion";

t.test("it works", async (t) => {
t.equal(isBuiltinModule("fs"), true);
Expand All @@ -9,3 +10,16 @@ t.test("it works", async (t) => {
t.equal(isBuiltinModule("test"), false);
t.equal(isBuiltinModule(""), false);
});

t.test(
"it works with node:sqlite",
{
skip:
getMajorNodeVersion() < 24
? "node:sqlite is not available in older Node.js versions"
: undefined,
},
async (t) => {
t.equal(isBuiltinModule("node:sqlite"), true);
}
);
2 changes: 1 addition & 1 deletion library/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@types/xml2js": "^0.4.14",
"aws-sdk": "^2.1595.0",
"axios": "^1.8.4",
"better-sqlite3": "^11.2.0",
"better-sqlite3": "^11.9.1",
"bson-objectid": "^2.0.4",
"cookie-parser": "^1.4.6",
"eslint": "^9.23.0",
Expand All @@ -89,9 +89,9 @@
"globals": "^16.0.0",
"graphql": "^16.8.2",
"hono": "^4.4.2",
"koa-router": "^12.0.1",
"koa-v2": "npm:koa@^2.16.1",
"koa-v3": "npm:koa@^3.0.0",
"koa-router": "^12.0.1",
"mariadb": "^3.3.2",
"mongodb": "~6.9",
"mongodb-v4": "npm:mongodb@^4.0.0",
Expand Down
7 changes: 1 addition & 6 deletions scripts/run-tap.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,12 @@ if (process.env.CI) {
args += " --coverage-report=lcov";
}

// Enable the `--experimental-sqlite` flag for Node.js ^22.5.0
if ((major === 22 && minor >= 5) || major === 23) {
args += " --node-arg=--experimental-sqlite --node-arg=--no-warnings";
}

execSync(`tap ${args}`, {
stdio: "inherit",
env: {
...process.env,
AIKIDO_CI: "true",
// In v23 some sub-dependencies are calling require on a esm module triggering an experimental warning
NODE_OPTIONS: major === 23 ? "--disable-warning=ExperimentalWarning" : "",
NODE_OPTIONS: major === 24 ? "--disable-warning=ExperimentalWarning" : "",
},
});