Reduce compressed stats per operation from 100 -> 20#610
Merged
Conversation
We keep durations of invocations to measure how long our algo takes to detect attacks. So per `fs.readFile` or `mysql.query`... When 5000 samples are reached, we compress the durations into percentiles. 100 * 5000 = 5M durations That's a lot per operation. I think we can reduce this to 100K invocations per operation :) So that we only keep 20 compressed percentiles per operation. If we go over this 20, we drop the oldest compressed percentiles.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
timokoessler
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep durations of invocations to measure how long our algo takes to detect attacks. So per
fs.readFileormysql.query...When 5000 samples are reached, we compress the durations into percentiles.
100 * 5000 = 5M durations
That's a lot per operation. I think we can reduce this to 100K invocations per operation :)
So that we only keep 20 compressed percentiles per operation.
If we go over this 20, we drop the oldest compressed percentiles.