Skip to content

Add extra comments #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willem-delbare merged 3 commits into from
May 20, 2025
Merged

Add extra comments #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f7b5b8
Add extra comments
hansott May 20, 2025
75c8bc6
Improve comment
hansott May 20, 2025
2b37e12
Improve comment
hansott May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions library/helpers/safeDecodeURIComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ const HEX = {
* Decodes a URI component, returning undefined if the URI is invalid.
* This function is a safe alternative to `decodeURIComponent`, which throws
* an error if the URI is malformed.
*
* We use this for performance reasons (throwing errors is very slow).
*/
export function safeDecodeURIComponent(uri: string): string | undefined {
let percentPosition = uri.indexOf("%");
Expand Down
3 changes: 3 additions & 0 deletions library/sources/http-server/checkIfRequestIsBlocked.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ const checkedBlocks = Symbol("__zen_checked_blocks__");
* - Whether the user agent is blocked by a user agent blocklist
*/
export function checkIfRequestIsBlocked(
// This flag is used to determine whether the request has already been checked
// We use a Symbol so that we don't accidentally overwrite any other properties on the response object
// and that we're the only ones that can access it
res: ServerResponse & { [checkedBlocks]?: boolean },
agent: Agent
): boolean {
Expand Down