Skip to content

Add 3 retry attempts to unit tests #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hansott merged 4 commits into from
Jan 6, 2026
Merged

Add 3 retry attempts to unit tests #871

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b6c1f2
Add 3 retry attempts to unit tests
bitterpanda63 Jan 6, 2026
ded29de
linting
bitterpanda63 Jan 6, 2026
98bd388
set timeout at 2hrs
bitterpanda63 Jan 6, 2026
82c577b
Change limit to 45 (3x15) for unit-test.yml
bitterpanda63 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ permissions:
jobs:
test:
runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 45
strategy:
fail-fast: false

Expand Down Expand Up @@ -82,17 +82,29 @@ jobs:
with:
name: firewall-node-library-${{ github.sha }}

- name: Run tests with current instrumentation
run: npm run test:ci
- name: Run tests with current instrumentation (max 3 attempts)
if: ${{ matrix.new-instrumentation == 'current' }}
uses: nick-fields/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # v2.9.0
with:
timeout_minutes: 15
max_attempts: 3
command: npm run test:ci

- name: Run tests with new instrumentation in CJS mode
run: npm run test:ci:new
- name: Run tests with new instrumentation in CJS mode (max 3 attempts)
if: ${{ matrix.new-instrumentation == 'new' && matrix.mode == 'cjs' }}
uses: nick-fields/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # v2.9.0
with:
timeout_minutes: 15
max_attempts: 3
command: npm run test:ci:new

- name: Run tests in ESM mode
run: npm run test:esm
- name: Run tests in ESM mode (max 3 attempts)
if: ${{ matrix.new-instrumentation == 'new' && matrix.mode == 'esm' }}
uses: nick-fields/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # v2.9.0
with:
timeout_minutes: 15
max_attempts: 3
command: npm run test:esm

- name: "Upload coverage"
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
Expand Down
Loading