Fixed Bypassed IPs not returning populated should_block_request decision structure#401
Merged
tudor-timcu merged 7 commits intomainfrom Mar 17, 2026
Merged
Conversation
- Introduced `env.json` for environment variables related to Aikido blocking. - Created `index.php` to handle requests and block specific IPs based on Aikido's decision. - Added `start_config.json` for initial configuration settings, including allowed IPs and rate limiting. - Implemented `test.py` to validate that requests from bypassed IPs return the expected response without crashing.
- Consolidated the bypass check for Aikido into a single conditional statement. - Ensured that the return value is initialized with default values to prevent unintended behavior when an IP is bypassed.
…ndling - Updated the gRPC library version in both agent and request-processor modules. - Adjusted test assertions to reflect changes in response handling for bypassed IPs. - Added a new assertion to check that the response does not contain a null decision message.
tudor-timcu
changed the title
- Simplified the conditional checks for Aikido bypass status. - Ensured early return for bypassed IPs to prevent unnecessary processing. - Maintained initialization of return value for consistent behavior.
PopoviciMarian
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Aikido
⚡ Enhancements
🐛 Bugfixes
🔧 Refactors
More info