Skip to content

fix: Give default value to user.name in set_user#475

Merged
bitterpanda63 merged 1 commit intoAikidoSec:fix-name-keyerrorfrom
henrygoodman:fix-name-keyerror
Sep 11, 2025
Merged

fix: Give default value to user.name in set_user#475
bitterpanda63 merged 1 commit intoAikidoSec:fix-name-keyerrorfrom
henrygoodman:fix-name-keyerror

Conversation

@henrygoodman
Copy link
Copy Markdown
Contributor

@henrygoodman henrygoodman commented Sep 11, 2025

Hi all, new to this repo and just wondering about below. Happy for any feedback

Issue:

Currently, calling set_user({"id": "user_id"}) (not specifying name) is allowed, however set_user assumes that validate_user returns a dict with a name key, resulting in a KeyError if name is not provided.

Fix:

  • Make this a required field, or
  • Set default empty str to avoid raising KeyError
    • I believe the Users UI actually requires the name to be populated, otherwise it doesn't display

@henrygoodman henrygoodman changed the title fix: Give default value to user name in set_user fix: Give default value to user.name in set_user Sep 11, 2025
@bitterpanda63 bitterpanda63 changed the base branch from main to fix-name-keyerror September 11, 2025 08:41
@bitterpanda63
Copy link
Copy Markdown
Member

Hi, is indeed a bug, thanks for creating a fix! Will merge into a feature branch and add some unit tests to avoid regression here

@bitterpanda63 bitterpanda63 merged commit 9348ab5 into AikidoSec:fix-name-keyerror Sep 11, 2025
53 of 54 checks passed
@bitterpanda63
Copy link
Copy Markdown
Member

This is now fixed in our latest release, thanks for helping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants