fix: Give default value to user.name in set_user#475
Merged
bitterpanda63 merged 1 commit intoAikidoSec:fix-name-keyerrorfrom Sep 11, 2025
Merged
fix: Give default value to user.name in set_user#475bitterpanda63 merged 1 commit intoAikidoSec:fix-name-keyerrorfrom
set_user#475bitterpanda63 merged 1 commit intoAikidoSec:fix-name-keyerrorfrom
Conversation
set_userset_user
bitterpanda63
approved these changes
Sep 11, 2025
Member
|
Hi, is indeed a bug, thanks for creating a fix! Will merge into a feature branch and add some unit tests to avoid regression here |
9348ab5
into
AikidoSec:fix-name-keyerror
53 of 54 checks passed
Member
|
This is now fixed in our latest release, thanks for helping! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, new to this repo and just wondering about below. Happy for any feedback
Issue:
Currently, calling
set_user({"id": "user_id"})(not specifying name) is allowed, howeverset_userassumes thatvalidate_userreturns a dict with anamekey, resulting in aKeyErrorif name is not provided.Fix:
KeyErrorUsersUI actually requires the name to be populated, otherwise it doesn't display