Cache protectionForcedOff in context#486
Merged
bitterpanda63 merged 15 commits intomainfrom Sep 29, 2025
Merged
Conversation
…with conflicts in global obj" This reverts commit 508e9a3.
hansott
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now cache protectionForcedOff, this helps performance for requests where there are thousands of operations that need to be scanned, this can cause conflicts calculating whether protection is forced off under high loads and degrading performance.
Simply: global objects are less performant, especially for single-interpreter apps, compared to context variables.