Fix Regexp::TimeoutError SQL injection bypass#258
Open
Conversation
for detecting numbers and comma-separated list of numbers.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
Around numbers and in comma-separated lists of numbers.
marksmith
force-pushed
the
return-attack-on-regexp-timeout-error
branch
from
caa4afc to
1e13f60
Compare
On Ruby < 3.2.
With default timeout from redos_regex_timeout configuration option.
timokoessler
approved these changes
Mar 25, 2026
kapyteinaikido
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Ruby 3.2, if
Regexp.timeoutis set, regular expression matching is aborted afterRegexp.timeoutby raisingRegexp::TimeoutError. Since Rails 8.0,Regexp.timeoutis set to 1 second by default. This change treats aRegexp::TimeoutErrorduring SQL injection detection as an attack.Summary by Aikido
⚡ Enhancements
🐛 Bugfixes
🔧 Refactors
More info